community.proxysql icon indicating copy to clipboard operation
community.proxysql copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

Added missing gtid_port to proxysql_backend_servers module

Open thanos-k opened this issue 3 years ago • 1 comments

SUMMARY

Added missing gtid_port to proxysql_backend_servers module

Fixes #117

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules/proxysql_backend_servers

thanos-k avatar Oct 16 '22 16:10 thanos-k

@thanos-k Thanks for the quick PR.
We need also an integration test, that verified that the parameter is working correctly. Mainly test to change the gtid_port of an existing row/record.

You can try to expand the existing test: https://github.com/ansible-collections/community.proxysql/tree/main/tests/integration/targets/test_proxysql_backend_servers/tasks, but it's difficult to see through.
You can also just add a new taskfile in tests/integration/targets/test_proxysql_backend_servers/ and include it at the end of the main.yml

markuman avatar Oct 17 '22 07:10 markuman