community.network icon indicating copy to clipboard operation
community.network copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

Prepare un-flatmapping

Open felixfontein opened this issue 3 years ago • 1 comments
trafficstars

SUMMARY

Prepares un-flatmapping. When collapsing the tests/unit/plugins/modules directory tree, there are some clashes because there are different fixtures directories in the tree structure. This PR renames these fixtures directories by prepending them with the module group names.

Also removes some string wrapping so that automatic replacements work.

With these changes, https://gist.github.com/felixfontein/3123dcdf446c9e140949a0589cceb99d can remove flatmapping and at least the Python 3.10 unit tests still pass :)

Ref: https://github.com/ansible-community/community-topics/issues/147

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

unit tests

felixfontein avatar Oct 12 '22 07:10 felixfontein

Currently contains #470.

felixfontein avatar Oct 16 '22 11:10 felixfontein

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/a1f1593ed3a7020d2c1bc9b343f850b8ab4a1c0a/pr-469

Backported as https://github.com/ansible-collections/community.network/pull/472

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Oct 26 '22 05:10 patchback[bot]

@Andersson007 @russoz thanks a lot for reviewing this!

felixfontein avatar Oct 26 '22 05:10 felixfontein