community.network icon indicating copy to clipboard operation
community.network copied to clipboard

icx_vlan - add stack and modules - fix purge with aggregate

Open dark-nico opened this issue 2 years ago • 3 comments

SUMMARY

Remove the hardcoded "ethernet 1/1/" to allow stack and modules to work. Fix module not adding interfaces when purge = true with aggregate "Fixes #268"

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

icx_vlan

ADDITIONAL INFORMATION

Picked up on PR#279 which seems to be abandoned. I use ratneshnagori work and made a few tweaks to make it works. I'll add the changelog fragment when the PR number will be generated. I can't see the CI failures on the other PR because it's too old. Maybe it need some more adjustments. Be kind, it's my first PR.. ever.

dark-nico avatar Apr 26 '22 21:04 dark-nico

I'll check what's wrong with test_icx_vlan_interfaces_cndt and test_icx_vlan_tagged_cndt

dark-nico avatar Apr 27 '22 08:04 dark-nico

CI tests failled with :00:30 ERROR! Error when getting collection version metadata for ansible.utils:2.6.0 from default (https://galaxy.ansible.com/api/) (HTTP Code: 429, Message: Too Many Requests Code: Unknown)

I think it just need to be run again to be cleared.

dark-nico avatar Apr 28 '22 07:04 dark-nico

cc @Commscope @sushma-alethea click here for bot help

ansibullbot avatar Jun 09 '22 08:06 ansibullbot