community.network
community.network copied to clipboard
ansible-collections
Update eric_eccli.py
Correction to work with the IPOS v21
SUMMARY
Corrects the exception thrown on connect.
ISSUE TYPE
- Bugfix Pull Request
COMPONENT NAME
eric_eccli plugin
ADDITIONAL INFORMATION
I assume this code did work at somepoint, have the commands changed prior to IPOS v21?
Will this change still work with older versions?
That I don't know. I have been trying to find a contact at Ericsson that develops the IPOS software, to ask the questions. I know that the 'screen-length 0' and 'screen-width 512' commands are not a options on the IPOS v21 software. So, a new eric_eccli plugin be created to support IPOS >= 21 ?
Ericsson is saying that they are unable to find the “screen-length” and “screen-width” commands on the IPOS R18 software. So, what are our steps for getting the Ansible module updated?
@kb5879gm hello, thanks for the fix! So those obsolete commands are not present in IPOS R18, right? Is IPOS R18 the oldest device when the commands are not present?
Anyway, is it possible to get a device version within the code? If yes we could add a condition logically saying if version >= IPOS R18: use this code; else: use the old code.
What do you think?
cc @itercheng @Khurram703 (i saw you were interested in this stuff) @Ansibleyou @ghost (you folks contributed to the related stuff) if anyone takes a look and shares their thoughts, it would be great
I am good with doing a condition on the version.
Sent from my iPhone
On Mar 8, 2022, at 3:41 AM, Andrew Klychkov @.***> wrote:
cc @itercheng @Khurram703 (i saw you were interested in this stuff) @Ansibleyou @ghost (you folks contributed to the related stuff) if anyone takes a look and shares their thoughts, it would be great
— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.
@kb5879gm cool, if the condition is implemented, i could merge the PR without further reviews. thank you!
Not sure why this pull request is still in Open status. I can confirm that the change is correct since I'm working with Ericsson IPOS currently.....
@Andersson007 is it possible to merge this change? Not sure why it didn't get merged.
@OpenSourceJimYan hi, oh, sorry, i misunderstood the conversation, so if it's still relevant:
- There was a talk about the condition, it wasn't done as far as i can see
- There should also be a changelog fragment added
@kb5879gm can you finish this? If not can anyone else finish the PR (feel free to create a replacing PR)?
@OpenSourceJimYan if the original author will not respond within a couple of days, would you like to finish it? If you have no experience with GH, here's a quick start guide.
@OpenSourceJimYan if the original author will not respond within a couple of days, would you like to finish it? If you have no experience with GH, here's a quick start guide.
Thank you very much. Yeah I would more than happy to learn how to do it. Let's wait for a couple of days first.
@OpenSourceJimYan if the original author will not respond within a couple of days, would you like to finish it? If you have no experience with GH, here's a quick start guide.
Thank you very much. Yeah I would more than happy to learn how to do it. Let's wait for a couple of days first.
Great thanks! Feel free to start in a couple of days then, please put it explicitly in comment here. Also if there are any questions along the way, I'd be happy to help, just ask