community.mysql
community.mysql copied to clipboard
Draft: Add options to start and stop group replication
SUMMARY
- Added options to start and stop group replication
ISSUE TYPE
- Feature Pull Request
COMPONENT NAME
mysql_replication moodule
ADDITIONAL INFORMATION
Codecov Report
Merging #93 (0883f8a) into main (31bd2b5) will decrease coverage by
1.48%. The diff coverage is8.10%.
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 75.07% 73.58% -1.49%
==========================================
Files 12 12
Lines 1645 1681 +36
Branches 423 431 +8
==========================================
+ Hits 1235 1237 +2
- Misses 267 301 +34
Partials 143 143
| Impacted Files | Coverage Δ | |
|---|---|---|
| plugins/modules/mysql_replication.py | 62.37% <8.10%> (-7.90%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 31bd2b5...0883f8a. Read the comment docs.
@eryx12o45 hi, thanks for the PR. It's a draft but anyway, please
- add a changelog fragment
- add tests to make CI green
- maybe it's worth adding underscores to the new values to make them more human friendly?
Thanks!
@Andersson007 thanks for the comments. I've added a changelog fragment and renamed the commands. Unfortunately I will not be able to provide tests in the near future, because of time constraints and the fact, that I would need to extend the setup routine to add group replication configs, etc. otherwise the commands would never work :-(
@betanummeric @laurent-indermuehle @bmalynovytch @rsicart @Jorge-Rodriguez what do you think about these changes? Can we merge it w/o tests? (provided that the fragment is fixed)
This PR needs rebase. I would wait for #63 to be merged and then rework these changes on top of it. Then we could add tests as well.
@eryx12o45 could you please rebase the PR? if you have no time, let us know
New version here --> https://github.com/ansible-collections/community.mysql/pull/647