community.libvirt icon indicating copy to clipboard operation
community.libvirt copied to clipboard

Refactor all plugins for better maintenance

Open odyssey4me opened this issue 5 years ago • 2 comments

SUMMARY

Each of the modules are independent bits of code, but we could refactor them all to use common objects, methods, etc which would make their implementations more consistent and easier to maintain.

There are also some great ideas and samples in https://github.com/ansible/ansible/issues/27905 which are worth looking at.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME
ADDITIONAL INFORMATION

odyssey4me avatar May 01 '20 13:05 odyssey4me

Hi odyssey4me,

because of the issue #47, I stumbled across this issue.

I wonder what is the status or plan here? Should we fix #47 or do we have some joint capacity to rewrite the network plugin?

simsiem avatar Nov 02 '20 09:11 simsiem

I would sincerely love some help to work on refactoring. I'm hoping to make some time to get to it, but I'm sensitive to the fact that any refactoring should involve ensuring decent test coverage first. If you're able to help with that, then it'd go a long way to improving the quality and maintainability of the modules.

odyssey4me avatar Nov 02 '20 12:11 odyssey4me