community.grafana icon indicating copy to clipboard operation
community.grafana copied to clipboard

fix: get latest grafana versions

Open Nemental opened this issue 10 months ago • 1 comments

SUMMARY
  • increase number of returned releases by api to ensure the newest 3 majors are included
  • refactor comparation of version numbers
    • work with multi digits major versions
    • compare versions as tulpe not as int
      • before: 10.0.13 (as_int: 10013) > 10.2.6 (as_int: 1026) (older version is higher)
      • after: 10.0.13 (as_tulpe: (10, 0, 13)) < 10.2.6 (as_tulpe: (10, 2, 6)) (newer version is higher)
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

before:

["9.5.18", "10.0.13"]

after:

["8.5.27", "9.5.18", "10.4.1"]

Nemental avatar Apr 05 '24 09:04 Nemental

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.46%. Comparing base (a3056e9) to head (451cc3c). Report is 5 commits behind head on main.

:exclamation: Current head 451cc3c differs from pull request most recent head cff474c. Consider uploading reports for the commit cff474c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   71.18%   74.46%   +3.28%     
==========================================
  Files          18       14       -4     
  Lines        1898     1719     -179     
  Branches      332      312      -20     
==========================================
- Hits         1351     1280      -71     
+ Misses        402      293     -109     
- Partials      145      146       +1     
Flag Coverage Δ
integration 70.04% <ø> (ø)
sanity ?
units 65.08% <ø> (-0.11%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 05 '24 09:04 codecov[bot]

They released a preview right after my changes to the python script :D Now all pre-release (-) and build-release tags (+) are skipped according to the semantic version

Nemental avatar Apr 12 '24 15:04 Nemental

failed sanity workflow is fixed in #355

Nemental avatar Apr 12 '24 15:04 Nemental

lgtm

rndmh3ro avatar Apr 18 '24 07:04 rndmh3ro