community.grafana icon indicating copy to clipboard operation
community.grafana copied to clipboard

feat: add module grafana_contact_point

Open Nemental opened this issue 11 months ago • 2 comments

SUMMARY

New module for management of contact points, introduced with the new Grafana Unified Alerting in Grafana 8.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Nemental avatar Feb 28 '24 17:02 Nemental

Codecov Report

Attention: Patch coverage is 73.21429% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 74.44%. Comparing base (101d40c) to head (9175486). Report is 14 commits behind head on main.

:exclamation: Current head 9175486 differs from pull request most recent head eff27c7

Please upload reports for the commit eff27c7 to get more accurate results.

Files Patch % Lines
plugins/modules/grafana_contact_point.py 73.21% 18 Missing and 12 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   72.00%   74.44%   +2.43%     
==========================================
  Files          20       15       -5     
  Lines        2097     1831     -266     
  Branches      356      340      -16     
==========================================
- Hits         1510     1363     -147     
+ Misses        431      311     -120     
- Partials      156      157       +1     
Flag Coverage Δ
integration 70.23% <72.32%> (-0.46%) :arrow_down:
sanity ?
units 65.18% <ø> (+1.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 28 '24 17:02 codecov[bot]

@rndmh3ro I don't think it's ready to merge but maybe it's time for a first review :) Maybe you have some time take a look. Next I want to do the documentation of the arguments in module file, so please ignore this for the moment :D

Nemental avatar Mar 21 '24 20:03 Nemental

@rndmh3ro finally ready to review 🎉 hopefully the tests are enough, I can't see it anymore 🫨

Nemental avatar May 28 '24 11:05 Nemental