community.grafana icon indicating copy to clipboard operation
community.grafana copied to clipboard

Support alertmanager Grafana datasource

Open jgosmann opened this issue 2 years ago • 2 comments

SUMMARY

This adds the "alertmanager" datasource. Apparently added in Grafana 9.2.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

grafana_datasource plugin

jgosmann avatar Oct 25 '22 18:10 jgosmann

Hi @jgosmann,

Please add integration tests and a changelog fragment to ha e CI pass.

thx 🙏🏻 !

rrey avatar Oct 30 '22 11:10 rrey

Codecov Report

Merging #287 (cef4115) into main (324fcf7) will increase coverage by 3.49%. The diff coverage is 0.00%.

:exclamation: Current head cef4115 differs from pull request most recent head 9f8a264. Consider uploading reports for the commit 9f8a264 to get more accurate results

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   70.31%   73.80%   +3.49%     
==========================================
  Files          17       13       -4     
  Lines        1772     1596     -176     
  Branches      294      275      -19     
==========================================
- Hits         1246     1178      -68     
+ Misses        389      281     -108     
  Partials      137      137              
Flag Coverage Δ
integration 68.36% <0.00%> (-0.10%) :arrow_down:
sanity ?
units 65.69% <0.00%> (-0.14%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/grafana_datasource.py 75.13% <0.00%> (-0.81%) :arrow_down:
plugins/modules/grafana_plugin.py 25.47% <0.00%> (-2.84%) :arrow_down:
plugins/modules/grafana_organization.py 83.33% <0.00%> (-1.18%) :arrow_down:
plugins/modules/grafana_folder.py 74.74% <0.00%> (-1.02%) :arrow_down:
plugins/modules/grafana_notification_channel.py 57.07% <0.00%> (-0.49%) :arrow_down:
plugins/modules/grafana_dashboard.py 51.76% <0.00%> (-0.40%) :arrow_down:
plugins/lookup/grafana_dashboard.py
plugins/doc_fragments/basic_auth.py
plugins/doc_fragments/api_key.py
plugins/callback/grafana_annotations.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 02 '22 07:11 codecov[bot]

Hey, I'd be interested in being able to do this too. I see the tests were added but the PR has become stale. Is there any hope of resurrecting this PR @jgosmann or one of the maintainers? Or would it be best to create a new one?

BenjaminSchubert avatar Aug 09 '24 16:08 BenjaminSchubert

I don't think there's anything I can do at the moment. Still waiting for a review. 😅

jgosmann avatar Aug 09 '24 17:08 jgosmann

Hey @jgosmann, I've resolved the conflicts and made a few other small changes. Tomorrow I'll do the final review and take a look over the tests, it's just too late for that now. Many thanks for the PR and your contribution!

Nemental avatar Aug 09 '24 20:08 Nemental