community.grafana icon indicating copy to clipboard operation
community.grafana copied to clipboard

Add support for more elasticsearch version as datasource

Open rrey opened this issue 2 years ago • 2 comments

SUMMARY

In latest versions of Grafana, the elastic version is no more provided as an integer even if it is still supported and won't return any error. To ease configuration, the module will accept the version format as displayed by the WUI (ex: "7.10+") and will map the value to what the API expects ("7.10.0"). The added values are the one supported by Grafana 8 and 9 (greater than elastic 7.0 which was already supported).

The module will keep on supporting the old format to avoid a breaking change with significant impact. The integer format could be dropped when Grafana 10 would be released since the versions we support would be 8.x to 10.x that will all support the new format.

Fixes: #263

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

grafana_datasource

rrey avatar Aug 22 '22 13:08 rrey

@kongslund would you have time to review this patch ?

rrey avatar Aug 22 '22 13:08 rrey

Codecov Report

Merging #274 (e0096d4) into main (75b9200) will increase coverage by 0.15%. The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   70.15%   70.31%   +0.15%     
==========================================
  Files          17       17              
  Lines        1766     1772       +6     
  Branches      324      292      -32     
==========================================
+ Hits         1239     1246       +7     
- Misses        388      389       +1     
+ Partials      139      137       -2     
Flag Coverage Δ
integration 68.46% <77.77%> (+0.08%) :arrow_up:
sanity 22.94% <11.11%> (-0.03%) :arrow_down:
units 65.83% <55.55%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/grafana_datasource.py 75.93% <77.77%> (+1.35%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 22 '22 13:08 codecov[bot]

Do we have an idea when this can be merged to mainline?

33Fraise33 avatar Oct 06 '22 07:10 33Fraise33

@33Fraise33 release 1.5.3 is on its way to Galaxy

rrey avatar Oct 06 '22 19:10 rrey