community.grafana icon indicating copy to clipboard operation
community.grafana copied to clipboard

fix(dashboard): specify utf-8 as encoding when opening files

Open rrey opened this issue 2 years ago • 2 comments

SUMMARY

No method of reproduction was found/provided for #191, as a prevention measure this patch specifies the encoding to use when opening a file to avoid the open function to auto determine the preferred encoding based on the locale.

Closes: #191

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

grafana_dashboard

rrey avatar Aug 22 '22 08:08 rrey

@kongslund could you review this patch ? 🙏

rrey avatar Aug 22 '22 08:08 rrey

Codecov Report

Merging #273 (defa8b9) into main (083f0b7) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   70.31%   70.31%           
=======================================
  Files          17       17           
  Lines        1772     1772           
  Branches      294      294           
=======================================
  Hits         1246     1246           
  Misses        389      389           
  Partials      137      137           
Flag Coverage Δ
integration 68.46% <100.00%> (ø)
sanity 22.94% <0.00%> (ø)
units 65.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/grafana_dashboard.py 52.15% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 22 '22 08:08 codecov[bot]