community.grafana icon indicating copy to clipboard operation
community.grafana copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

Integration tests with grafana image

Open rockaut opened this issue 5 years ago • 2 comments

SUMMARY

Currently the integration tests are running against python:3.6 image and grafana service containers. While there are unit tests to check things like grafana_plugin. It would be nice and way easier to also have integration tests which runs directly against the grafana containers. Imo it would not only be easier to write but also would be easier to check against things like #103 ?

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

Tests

rockaut avatar Jul 28 '20 14:07 rockaut

+1 to that ! The unittests were a quick win At the time, integration tests would be better for the objective of the test realized for this module.

rrey avatar Jul 28 '20 18:07 rrey

I yesterday tried to set up an additional job but I haven't done any github workflow other than clicking through it. First problem is, the default grafana image is non-root so a separate image is needed. Is there a way to build an image and use that for the rest of the flow? If someone can point me to the instructions for that I would implement it. Couldn't find something with quick googling yesterday.

rockaut avatar Jul 29 '20 06:07 rockaut