community.general icon indicating copy to clipboard operation
community.general copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

Fix to handle Redfish Gen2 Firmware upgrade

Open cmadarsh opened this issue 1 year ago • 9 comments

SUMMARY

Fix to enable firmware upgrade on our Gen2 redfish based UltraStar Data102 platform.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

wdc_redfish_command module

ADDITIONAL INFORMATION

Firmware upgrade in case of Gen2 UltraStar Data102 platform is handled with the new firmware bundle format.

cmadarsh avatar May 31 '24 11:05 cmadarsh

cc @mikemoerk click here for bot help

ansibullbot avatar May 31 '24 11:05 ansibullbot

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/module_utils/wdc_redfish_utils.py:213:27: disallowed-name: Disallowed name "_"

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/module_utils/wdc_redfish_utils.py:213:27: disallowed-name: Disallowed name "_"

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/module_utils/wdc_redfish_utils.py:213:27: disallowed-name: Disallowed name "_"

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/module_utils/wdc_redfish_utils.py:213:27: disallowed-name: Disallowed name "_"

click here for bot help

ansibullbot avatar May 31 '24 11:05 ansibullbot

Thanks for your contribution! Please check the failing sanity tests, and add a changelog fragment. Thanks.

felixfontein avatar Jun 01 '24 19:06 felixfontein

Ready for review

cmadarsh avatar Jun 05 '24 05:06 cmadarsh

Should the documentation of the wdc_redfish_command module also be updated to mention this somehow?

By default wdc_redfish_command module should work irrespective of the Redfish platform versions. I feel it need not be documented.

cmadarsh avatar Jun 11 '24 15:06 cmadarsh

Ready for review

cmadarsh avatar Jun 11 '24 16:06 cmadarsh

Ready for Review

cmadarsh avatar Jun 20 '24 12:06 cmadarsh

I cannot judge the actual change. If nobody objects, I'll merge this in 1-2 weeks.

felixfontein avatar Jun 27 '24 11:06 felixfontein

I cannot judge the actual change. If nobody objects, I'll merge this in 1-2 weeks.

Ok, please merge, the changes are specific to Western Digital platform and its modules, which has been tested.

cmadarsh avatar Jun 28 '24 04:06 cmadarsh

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/feb1ecbfcddcc417bbae672674e080d3f6d1894d/pr-8444

Backported as https://github.com/ansible-collections/community.general/pull/8600

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Jul 08 '24 07:07 patchback[bot]

@cmadarsh thanks for your contribution!

felixfontein avatar Jul 08 '24 07:07 felixfontein

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/feb1ecbfcddcc417bbae672674e080d3f6d1894d/pr-8444

Backported as https://github.com/ansible-collections/community.general/pull/8601

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Jul 08 '24 07:07 patchback[bot]