community.general icon indicating copy to clipboard operation
community.general copied to clipboard

Added startup configuration option

Open miccico opened this issue 1 year ago • 2 comments
trafficstars

SUMMARY

Currently all containers that are created using this module start at the same time at system boot. In order to be able to reflect service dependencies and spread initial startup load proxmox supports the configuration of a startup parameter. This pull request adds the option to configure startup behavior of lxc containers. It works well in conjunction with onboot and allows to set startup order, startup delay and shutdown delay.

Changelog Fragment

  • proxmox - adds startup parameters for configuring startup order, startup delay and shutdown delay.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

proxmox

ADDITIONAL INFORMATION
sample usage:
startup: 
      - order=10
      - up=50
      - down=20
    

miccico avatar Feb 27 '24 21:02 miccico

cc @Ajpantuso @Thulium-Drake @UnderGreen @joshainglis @karmab @krauthosting click here for bot help

ansibullbot avatar Feb 27 '24 21:02 ansibullbot

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/proxmox.py:87:127: W291: trailing whitespace
plugins/modules/proxmox.py:88:100: W291: trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/proxmox.py:87:127: W291: trailing whitespace
plugins/modules/proxmox.py:88:100: W291: trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/proxmox.py:87:127: W291: trailing whitespace
plugins/modules/proxmox.py:88:100: W291: trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/proxmox.py:87:127: W291: trailing whitespace
plugins/modules/proxmox.py:88:100: W291: trailing whitespace

click here for bot help

ansibullbot avatar Feb 27 '24 21:02 ansibullbot

Sorry guys - still a newbie on working with projects that have big infrastructures :)

miccico avatar Mar 22 '24 08:03 miccico

@miccico this PR contains the following merge commits:

  • https://github.com/ansible-collections/community.general/commit/34c6daff7a42f2bbc0d3138be78f5c2a5d68af9b

Please rebase your branch to remove these commits.

click here for bot help

ansibullbot avatar Mar 22 '24 08:03 ansibullbot

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/795a855d0e0b319f270f869a0b1793acaba43ea3/pr-8038

Backported as https://github.com/ansible-collections/community.general/pull/8142

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Mar 24 '24 21:03 patchback[bot]

@miccico thanks for your contribution! @krauthosting thanks for reviewing!

felixfontein avatar Mar 24 '24 21:03 felixfontein