community.general
community.general copied to clipboard
ansible-collections
firmware update
SUMMARY
New module_util request Adding a new module_utils file for the purpose of Updating, Getting Info, fetching the Power_Status. And the addition of three module files separately for Updating, fetching Inventory Info and Getting or modifying the power status.
ISSUE TYPE
- New Module/Plugin Pull Request
COMPONENT NAME
module_utils\hpc_system_firmware_utils.py
ADDITIONAL INFORMATION
@Srujana-2000 this PR contains the following merge commits:
- https://github.com/ansible-collections/community.general/commit/da265674ae2838426b53b89c9ab871b5f65c5fe1
Please rebase your branch to remove these commits.
@Srujana-2000 this PR contains the following merge commits:
- https://github.com/ansible-collections/community.general/commit/da265674ae2838426b53b89c9ab871b5f65c5fe1
- https://github.com/ansible-collections/community.general/commit/ed1a5324832b7fa8b00b27a3a4d837f44a7211f3
Please rebase your branch to remove these commits.
@Srujana-2000 this PR contains the following merge commits:
- https://github.com/ansible-collections/community.general/commit/d6040cfee9f8edd194e1521f11877023e3caa1cc
Please rebase your branch to remove these commits.
@Srujana-2000 this PR contains the following merge commits:
- https://github.com/ansible-collections/community.general/commit/d6040cfee9f8edd194e1521f11877023e3caa1cc
- https://github.com/ansible-collections/community.general/commit/749a1c6e60c6c08865aca26dabcc9128d9167eb2
Please rebase your branch to remove these commits.
@Srujana-2000 I suggest you take a look at https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md#creating-new-modules-or-plugins (again). New modules must come with tests. This PR does not contain any tests. Also adding more than one module in a PR is usually not a good idea. Finally, as I already wrote, since this is a contribution of a company to a community-driven collection, and does not rely on any existing content in this collection, it's better to create a new collection for this instead of adding it to this collection.
@Srujana-2000 this PR contains the following merge commits:
- https://github.com/ansible-collections/community.general/commit/d6040cfee9f8edd194e1521f11877023e3caa1cc
- https://github.com/ansible-collections/community.general/commit/749a1c6e60c6c08865aca26dabcc9128d9167eb2
- https://github.com/ansible-collections/community.general/commit/fff2ab298b2574d9a09881e10291002878c1dbe3
Please rebase your branch to remove these commits.
As per the comments I have added tests. Can we get confirmed if it's correct. And move forward for further process
We want to be in community general rather than creating a separate collection. Can we pls get confirmed about this
Can you explain why you would prefer the modules to be here instead of a separate collection?
Our products are already being supported through library inside community general and we want to extend the support for firmware upgrade by being in line with them. Also community general provides redfish support and other dependency, which is the core part of the upgrade so we wanted to be in community general collection. We would not prefer to again rewrite all the code for separate collection
@Srujana-2000 This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.
@Srujana-2000 You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.