community.general icon indicating copy to clipboard operation
community.general copied to clipboard

WIP: [Scaleway] Add new modules for serverless services

Open Lunik opened this issue 3 years ago • 6 comments

SUMMARY

THIS IS A WORK IN PROGRES PR

This PR add new modules to manage Scaleway serverless services (https://developers.scaleway.com).

Planned modules (and corresponding _info) :

  • Container registry
    • [x] module
    • [ ] _info
  • Function namespace
    • [x] module
    • [ ] _info
  • Function
    • [x] module
    • [ ] _info
  • Container namespace
    • [x] module
    • [ ] _info
  • Container
    • [x] module
    • [ ] _info
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • scaleway_container_registry
  • scaleway_function_namespace
ADDITIONAL INFORMATION

require evolution on Scaleway config in ansible-test : https://github.com/ansible/ansible/pull/79141

Lunik avatar Oct 14 '22 10:10 Lunik

cc @abarbare @remyleone click here for bot help

ansibullbot avatar Oct 14 '22 10:10 ansibullbot

The test botmeta failed with 1 error:

.github/BOTMETA.yml:0:0: Author Lunik not mentioned as active or inactive maintainer for plugins/modules/cloud/scaleway/scaleway_container_registry.py (mentioned are: remyleone, abarbare)

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['fr-par', 'nl-ams', 'pl-waw']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/cloud/scaleway/scaleway_container_registry.py:0:0: documentation-error: Unknown DOCUMENTATION error, see TRACE: while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: return-syntax-error: RETURN is not valid YAML

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc -t module community.general.scaleway_container_registry" returned exit status 0.
>>> Standard Error
[WARNING]: module community.general.scaleway_container_registry not found in:
/dev/null:/root/ansible/lib/ansible/modules

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 11 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 11 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 11 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 11 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 11 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module community.general.cloud.scaleway.scaleway_container_registry" returned exit status 1.
>>> Standard Error
ERROR! module community.general.cloud.scaleway.scaleway_container_registry missing documentation (or could not parse documentation): while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module community.general.cloud.scaleway.scaleway_container_registry" returned exit status 1.
>>> Standard Error
ERROR! module community.general.cloud.scaleway.scaleway_container_registry missing documentation (or could not parse documentation): community.general.cloud.scaleway.scaleway_container_registry did not contain a DOCUMENTATION attribute (/root/ansible_collections/community/general/plugins/modules/cloud/scaleway/scaleway_container_registry.py). Unable to parse documentation in python file '/root/ansible_collections/community/general/plugins/modules/cloud/scaleway/scaleway_container_registry.py': while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1. while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc -t module community.general.scaleway_container_registry" returned exit status 0.
>>> Standard Error
[WARNING]: module community.general.scaleway_container_registry not found in:
/dev/null:/root/ansible/lib/ansible/modules

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module community.general.cloud.scaleway.scaleway_container_registry" returned exit status 1.
>>> Standard Error
ERROR! module community.general.cloud.scaleway.scaleway_container_registry missing documentation (or could not parse documentation): community.general.cloud.scaleway.scaleway_container_registry did not contain a DOCUMENTATION attribute (/root/ansible_collections/community/general/plugins/modules/cloud/scaleway/scaleway_container_registry.py). Unable to parse documentation in python file '/root/ansible_collections/community/general/plugins/modules/cloud/scaleway/scaleway_container_registry.py': while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1. while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1

click here for bot help

ansibullbot avatar Oct 14 '22 10:10 ansibullbot

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:0: trailing-whitespace: Trailing whitespace

The test botmeta failed with 2 errors:

.github/BOTMETA.yml:0:0: Author Lunik not mentioned as active or inactive maintainer for plugins/modules/cloud/scaleway/scaleway_container_registry.py (mentioned are: remyleone, abarbare)
.github/BOTMETA.yml:0:0: Author Lunik not mentioned as active or inactive maintainer for plugins/modules/cloud/scaleway/scaleway_function_namespace.py (mentioned are: remyleone, abarbare)

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['fr-par', 'nl-ams', 'pl-waw']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/cloud/scaleway/scaleway_container_registry.py:0:0: documentation-error: Unknown DOCUMENTATION error, see TRACE: while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: return-syntax-error: RETURN is not valid YAML
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['fr-par', 'nl-ams', 'pl-waw']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc -t module community.general.scaleway_container_registry community.general.scaleway_function_namespace" returned exit status 0.
>>> Standard Error
[WARNING]: module community.general.scaleway_container_registry not found in:
/dev/null:/root/ansible/lib/ansible/modules
[WARNING]: module community.general.scaleway_function_namespace not found in:
/dev/null:/root/ansible/lib/ansible/modules

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 24 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:142:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:143:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:156:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:164:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:192:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:218:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:219:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:237:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:245:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:1: W293: blank line contains whitespace
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:252:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:257:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:275:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 24 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:142:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:143:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:156:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:164:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:192:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:218:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:219:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:237:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:245:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:1: W293: blank line contains whitespace
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:252:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:257:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:275:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 24 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:142:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:143:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:156:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:164:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:192:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:218:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:219:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:237:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:245:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:1: W293: blank line contains whitespace
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:252:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:257:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:275:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:0: trailing-whitespace: Trailing whitespace

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 24 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:142:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:143:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:156:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:164:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:192:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:218:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:219:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:237:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:245:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:1: W293: blank line contains whitespace
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:252:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:257:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:275:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:0: trailing-whitespace: Trailing whitespace

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: error: RETURN: syntax error: expected ',' or '}', but got '<stream end>' (syntax)
plugins/modules/cloud/scaleway/scaleway_container_registry.py:117:1: unparsable-with-libyaml: while parsing a flow mapping - did not find expected ',' or '}'

The test ansible-test sanity --test pep8 [explain] failed with 24 errors:

plugins/modules/cloud/scaleway/scaleway_container_registry.py:127:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:128:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_container_registry.py:137:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:145:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:173:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:199:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:200:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:218:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_container_registry.py:226:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:231:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_container_registry.py:248:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:142:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:143:15: E225: missing whitespace around operator
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:156:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:164:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:192:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:218:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:219:64: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:237:33: E128: continuation line under-indented for visual indent
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:245:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:1: W293: blank line contains whitespace
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:252:1: E305: expected 2 blank lines after class or function definition, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:257:1: E302: expected 2 blank lines, found 1
plugins/modules/cloud/scaleway/scaleway_function_namespace.py:275:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module community.general.cloud.scaleway.scaleway_container_registry community.general.cloud.scaleway.scaleway_function_namespace" returned exit status 1.
>>> Standard Error
ERROR! module community.general.cloud.scaleway.scaleway_container_registry missing documentation (or could not parse documentation): while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module community.general.cloud.scaleway.scaleway_container_registry community.general.cloud.scaleway.scaleway_function_namespace" returned exit status 1.
>>> Standard Error
ERROR! module community.general.cloud.scaleway.scaleway_container_registry missing documentation (or could not parse documentation): community.general.cloud.scaleway.scaleway_container_registry did not contain a DOCUMENTATION attribute (/root/ansible_collections/community/general/plugins/modules/cloud/scaleway/scaleway_container_registry.py). Unable to parse documentation in python file '/root/ansible_collections/community/general/plugins/modules/cloud/scaleway/scaleway_container_registry.py': while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1. while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc -t module community.general.scaleway_container_registry community.general.scaleway_function_namespace" returned exit status 0.
>>> Standard Error
[WARNING]: module community.general.scaleway_container_registry not found in:
/dev/null:/root/ansible/lib/ansible/modules
[WARNING]: module community.general.scaleway_function_namespace not found in:
/dev/null:/root/ansible/lib/ansible/modules

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:0: trailing-whitespace: Trailing whitespace

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module community.general.cloud.scaleway.scaleway_container_registry community.general.cloud.scaleway.scaleway_function_namespace" returned exit status 1.
>>> Standard Error
ERROR! module community.general.cloud.scaleway.scaleway_container_registry missing documentation (or could not parse documentation): community.general.cloud.scaleway.scaleway_container_registry did not contain a DOCUMENTATION attribute (/root/ansible_collections/community/general/plugins/modules/cloud/scaleway/scaleway_container_registry.py). Unable to parse documentation in python file '/root/ansible_collections/community/general/plugins/modules/cloud/scaleway/scaleway_container_registry.py': while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1. while parsing a flow mapping
  in "<unicode string>", line 6, column 13
did not find expected ',' or '}'
  in "<unicode string>", line 23, column 1

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/modules/cloud/scaleway/scaleway_function_namespace.py:246:0: trailing-whitespace: Trailing whitespace

click here for bot help

ansibullbot avatar Oct 14 '22 11:10 ansibullbot

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

github-actions[bot] avatar Oct 14 '22 11:10 github-actions[bot]

cc @sieben click here for bot help

ansibullbot avatar Oct 14 '22 13:10 ansibullbot

The test licenses failed with 2 errors:

tests/integration/inventory:0:0: found no copyright notice
tests/integration/inventory:0:0: must have at least one license

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_function.py:0:0: doc-choices-do-not-match-spec: Argument 'privacy' in argument_spec defines choices as ([]) but documentation defines choices as (['public', 'private'])
plugins/modules/cloud/scaleway/scaleway_function.py:0:0: parameter-documented-multiple-times: Argument 'api_timeout' in argument_spec with aliases 'timeout' is documented multiple times, namely as 'api_timeout', 'timeout'

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

plugins/module_utils/scaleway.py:101:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:107:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:112:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

plugins/module_utils/scaleway.py:96:12: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:97:18: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:99:10: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:101:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:105:77: undefined-variable: Undefined variable 'lb'
plugins/module_utils/scaleway.py:107:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:108:8: undefined-variable: Undefined variable 'time'

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

plugins/module_utils/scaleway.py:101:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:107:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:112:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

plugins/module_utils/scaleway.py:101:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:107:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:112:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

plugins/module_utils/scaleway.py:101:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:107:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:112:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

plugins/module_utils/scaleway.py:96:12: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:97:18: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:99:10: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:101:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:105:77: undefined-variable: Undefined variable 'lb'
plugins/module_utils/scaleway.py:107:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:108:8: undefined-variable: Undefined variable 'time'

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

plugins/module_utils/scaleway.py:96:12: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:97:18: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:99:10: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:101:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:105:77: undefined-variable: Undefined variable 'lb'
plugins/module_utils/scaleway.py:107:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:108:8: undefined-variable: Undefined variable 'time'

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

plugins/module_utils/scaleway.py:101:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:107:1: W293: blank line contains whitespace
plugins/module_utils/scaleway.py:112:1: E302: expected 2 blank lines, found 1

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

plugins/module_utils/scaleway.py:96:12: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:97:18: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:99:10: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:101:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:105:77: undefined-variable: Undefined variable 'lb'
plugins/module_utils/scaleway.py:107:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:108:8: undefined-variable: Undefined variable 'time'

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_function.py:0:0: doc-choices-do-not-match-spec: Argument 'privacy' in argument_spec defines choices as ([]) but documentation defines choices as (['public', 'private'])
plugins/modules/cloud/scaleway/scaleway_function.py:0:0: parameter-documented-multiple-times: Argument 'api_timeout' in argument_spec with aliases 'timeout' is documented multiple times, namely as 'api_timeout', 'timeout'

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_function.py:0:0: doc-choices-do-not-match-spec: Argument 'privacy' in argument_spec defines choices as ([]) but documentation defines choices as (['public', 'private'])
plugins/modules/cloud/scaleway/scaleway_function.py:0:0: parameter-documented-multiple-times: Argument 'api_timeout' in argument_spec with aliases 'timeout' is documented multiple times, namely as 'api_timeout', 'timeout'

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_function.py:0:0: doc-choices-do-not-match-spec: Argument 'privacy' in argument_spec defines choices as ([]) but documentation defines choices as (['public', 'private'])
plugins/modules/cloud/scaleway/scaleway_function.py:0:0: parameter-documented-multiple-times: Argument 'api_timeout' in argument_spec with aliases 'timeout' is documented multiple times, namely as 'api_timeout', 'timeout'

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/modules/cloud/scaleway/scaleway_function.py:0:0: doc-choices-do-not-match-spec: Argument 'privacy' in argument_spec defines choices as ([]) but documentation defines choices as (['public', 'private'])
plugins/modules/cloud/scaleway/scaleway_function.py:0:0: parameter-documented-multiple-times: Argument 'api_timeout' in argument_spec with aliases 'timeout' is documented multiple times, namely as 'api_timeout', 'timeout'

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

plugins/module_utils/scaleway.py:96:12: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:97:18: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:99:10: undefined-variable: Undefined variable 'datetime'
plugins/module_utils/scaleway.py:101:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:105:77: undefined-variable: Undefined variable 'lb'
plugins/module_utils/scaleway.py:107:0: trailing-whitespace: Trailing whitespace
plugins/module_utils/scaleway.py:108:8: undefined-variable: Undefined variable 'time'

click here for bot help

ansibullbot avatar Oct 14 '22 14:10 ansibullbot

ready_for_review

Lunik avatar Oct 19 '22 20:10 Lunik

Hi @Lunik, as mentioned by @felixfontein back then:

Please note CONTRIBUTING.md, especially the note on PRs with multiple new modules/plugins.

Specifically:

Please do not add more than one plugin/module in one PR, especially if it is the first plugin/module you are contributing. That makes it easier for reviewers, and increases the chance that your PR will get merged. If you plan to contribute a group of plugins/modules (say, more than a module and a corresponding _info module), please mention that in the first PR. In such cases, you also have to think whether it is better to publish the group of plugins/modules in a new collection.

I would be OK having the pair of modules ( and _info) in the same PR, after all they do refer to the exact same thing. But this PR is too big as it is.

russoz avatar Oct 20 '22 11:10 russoz

If I do as you says then in which one of the PR should I add the common parts (like module_utils and doc_fragments) ?

Lunik avatar Oct 20 '22 15:10 Lunik

In the first one.

russoz avatar Oct 20 '22 17:10 russoz

As suggested, I have splited this massive PR into multiple small ones. First will be #5399 and the others will follow once the common part in module_utils and doc_fragments are merged

Thank's @felixfontein / @russoz

Lunik avatar Oct 20 '22 20:10 Lunik