community.general icon indicating copy to clipboard operation
community.general copied to clipboard

mattermost: add support for icon_emoji Parameter

Open anx-ag opened this issue 2 years ago • 6 comments

  • Additionally support icon_emoji parameter
  • No default values for icon_url and icon_emoji (they're optional anyways)
SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

anx-ag avatar Aug 12 '22 07:08 anx-ag

cc @bjolivot click here for bot help

ansibullbot avatar Aug 12 '22 07:08 ansibullbot

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/modules/notification/mattermost.py:0:0: doc-default-does-not-match-spec: Argument 'icon_emoji' in argument_spec defines default as (None) but documentation defines default as ('None')
plugins/modules/notification/mattermost.py:0:0: doc-default-does-not-match-spec: Argument 'icon_url' in argument_spec defines default as (None) but documentation defines default as ('None')

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/modules/notification/mattermost.py:0:0: doc-default-does-not-match-spec: Argument 'icon_emoji' in argument_spec defines default as (None) but documentation defines default as ('None')
plugins/modules/notification/mattermost.py:0:0: doc-default-does-not-match-spec: Argument 'icon_url' in argument_spec defines default as (None) but documentation defines default as ('None')

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/modules/notification/mattermost.py:0:0: doc-default-does-not-match-spec: Argument 'icon_emoji' in argument_spec defines default as (None) but documentation defines default as ('None')
plugins/modules/notification/mattermost.py:0:0: doc-default-does-not-match-spec: Argument 'icon_url' in argument_spec defines default as (None) but documentation defines default as ('None')

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/modules/notification/mattermost.py:0:0: doc-default-does-not-match-spec: Argument 'icon_emoji' in argument_spec defines default as (None) but documentation defines default as ('None')
plugins/modules/notification/mattermost.py:0:0: doc-default-does-not-match-spec: Argument 'icon_url' in argument_spec defines default as (None) but documentation defines default as ('None')

click here for bot help

ansibullbot avatar Aug 12 '22 07:08 ansibullbot

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

github-actions[bot] avatar Aug 12 '22 07:08 github-actions[bot]

Changelog fragment has been added - please let me know if this is OK, is my first one...

anx-ag avatar Aug 13 '22 13:08 anx-ag

@anx-ag ping

needs_info

felixfontein avatar Sep 03 '22 10:09 felixfontein

@anx-ag This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

ansibullbot avatar Oct 05 '22 11:10 ansibullbot

Please note that in #5461 the collection repository was restructured to remove the directory tree in plugins/modules/, and the corresponding tree in tests/unit/plugins/modules/. Your PR modifies files in this directory structure, and unfortunately now has some conflicts, potentially because of this. Please rebase with the current main branch to remove the conflicts.

felixfontein avatar Nov 03 '22 05:11 felixfontein

@anx-ag You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help

ansibullbot avatar Nov 11 '22 07:11 ansibullbot