Change Proxmox `agent` argument to string.

[reitermarkus]

SUMMARY

Allow specifying Proxmox agent argument as string.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

proxmox_kvm

ADDITIONAL INFORMATION

The agent argument can not only be true or false (or 0/1) but also be a string, e.g. enabled=1,fstrim_cloned_disks=1.

Extracted from https://github.com/ansible-collections/community.general/pull/4027.

[ansibullbot]

cc @Ajpantuso @Thulium-Drake @helldorado @joshainglis @karmab @tleguern click here for bot help

[ansibullbot]

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/cloud/misc/proxmox_kvm.py:965:11: E111: indentation is not a multiple of 4
plugins/modules/cloud/misc/proxmox_kvm.py:967:11: E111: indentation is not a multiple of 4

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/cloud/misc/proxmox_kvm.py:965:11: E111: indentation is not a multiple of four
plugins/modules/cloud/misc/proxmox_kvm.py:967:11: E111: indentation is not a multiple of four

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/cloud/misc/proxmox_kvm.py:965:11: E111: indentation is not a multiple of 4
plugins/modules/cloud/misc/proxmox_kvm.py:967:11: E111: indentation is not a multiple of 4

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/cloud/misc/proxmox_kvm.py:965:11: E111: indentation is not a multiple of four
plugins/modules/cloud/misc/proxmox_kvm.py:967:11: E111: indentation is not a multiple of four

click here for bot help

[github-actions[bot]]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

[felixfontein]

If nobody from the maintainers complains, I'll merge somewhen this weekend.

[patchback[bot]]

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/0be7b6e7b91bb2d7b6e16773cc9b93a655ca0dd6/pr-5107

Backported as https://github.com/ansible-collections/community.general/pull/5130

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@reitermarkus thanks for improving this! @russoz thanks for reviewing!

[fritterhoff]

Hi,

this change actually breaks the proxmox_kvm module. (https://github.com/ansible-collections/community.general/issues/5360)

[felixfontein]

@fritterhoff that's rather old news, since that bug was fixed pretty shortly after this got merged (in #5198). Or do you still have this (exact) problem with the latest release?

[fritterhoff]

Nvm. Error seems to be fixed. Sorry :(