community.general icon indicating copy to clipboard operation
community.general copied to clipboard

New module: Proxmox disk management

Open castorsky opened this issue 1 year ago • 3 comments

SUMMARY

Add proxmox_disk module to provide management of virtual volumes in QEMU(KVM) virtual machines

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • proxmox_disk
ADDITIONAL INFORMATION

This module provides ability to manage disks in Proxmox VMs in such ways:

  • create disk (fresh new or import from existing image);
  • update disk (change some parameters, for example: iops limit, backup status);
  • move disk (between storages in one VM or to another VM);
  • grow size (shrinking not supported);
  • detach disk (leave it unused);
  • remove disk (permanently).

castorsky avatar Aug 09 '22 01:08 castorsky

cc @Ajpantuso @Thulium-Drake @joshainglis @karmab @tleguern click here for bot help

ansibullbot avatar Aug 09 '22 01:08 ansibullbot

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

github-actions[bot] avatar Aug 09 '22 02:08 github-actions[bot]

The test licenses failed with 4 errors:

plugins/modules/cloud/misc/proxmox_disk.py:0:0: found copyright line with "Copyright:". Please remove the colon.
plugins/modules/cloud/misc/proxmox_disk.py:0:0: SPDX-License-Identifier yielded the license list (empty), while manual guessing yielded the license list "GPL-3.0-or-later"
plugins/modules/cloud/misc/proxmox_disk.py:0:0: found no copyright notice
plugins/modules/cloud/misc/proxmox_disk.py:0:0: must have at least one license

The test ansible-test sanity --test validate-modules [explain] failed with 7 errors:

plugins/modules/cloud/misc/proxmox_disk.py:0:0: doc-required-mismatch: Argument 'action' in argument_spec is required, but is not documented as being required
plugins/modules/cloud/misc/proxmox_disk.py:0:0: implied-parameter-type-mismatch: Argument 'state' in argument_spec implies type as 'str' but documentation defines as 'string'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.name.typr: extra keys not allowed @ data['argument_spec']['name']['typr']. Got 'str'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.serial.typr: extra keys not allowed @ data['argument_spec']['serial']['typr']. Got 'str'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-documentation: DOCUMENTATION.options.state.type: not a valid value for dictionary value @ data['options']['state']['type']. Got 'string'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: parameter-invalid: Argument 'import-from' in argument_spec is not a valid python identifier
plugins/modules/cloud/misc/proxmox_disk.py:0:0: required_if-requirements-type: required_if must have third value (requirements) being a list or tuple; got type 'size'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:57:161: E501: line too long (184 > 160 characters)

The test ansible-test sanity --test no-smart-quotes [explain] failed with 10 errors:

plugins/modules/cloud/misc/proxmox_disk.py:51:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:127:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:132:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:145:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:150:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:225:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:252:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:256:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:265:22: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:284:18: use ASCII quotes `'` and `"` instead of Unicode quotes

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:57:161: E501: line too long (184 > 160 characters)

The test ansible-test sanity --test no-smart-quotes [explain] failed with 10 errors:

plugins/modules/cloud/misc/proxmox_disk.py:51:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:127:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:132:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:145:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:150:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:225:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:252:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:256:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:265:22: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:284:18: use ASCII quotes `'` and `"` instead of Unicode quotes

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:57:161: E501: line too long (184 > 160 characters)

The test ansible-test sanity --test no-smart-quotes [explain] failed with 10 errors:

plugins/modules/cloud/misc/proxmox_disk.py:51:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:127:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:132:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:145:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:150:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:225:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:252:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:256:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:265:22: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:284:18: use ASCII quotes `'` and `"` instead of Unicode quotes

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

The test ansible-test sanity --test validate-modules [explain] failed with 7 errors:

plugins/modules/cloud/misc/proxmox_disk.py:0:0: doc-required-mismatch: Argument 'action' in argument_spec is required, but is not documented as being required
plugins/modules/cloud/misc/proxmox_disk.py:0:0: implied-parameter-type-mismatch: Argument 'state' in argument_spec implies type as 'str' but documentation defines as 'string'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.name.typr: extra keys not allowed @ data['argument_spec']['name']['typr']. Got 'str'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.serial.typr: extra keys not allowed @ data['argument_spec']['serial']['typr']. Got 'str'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-documentation: DOCUMENTATION.options.state.type: not a valid value for dictionary value @ data['options']['state']['type']. Got 'string'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: parameter-invalid: Argument 'import-from' in argument_spec is not a valid python identifier
plugins/modules/cloud/misc/proxmox_disk.py:0:0: required_if-requirements-type: required_if must have third value (requirements) being a list or tuple; got type 'size'

The test ansible-test sanity --test validate-modules [explain] failed with 7 errors:

plugins/modules/cloud/misc/proxmox_disk.py:0:0: doc-required-mismatch: Argument 'action' in argument_spec is required, but is not documented as being required
plugins/modules/cloud/misc/proxmox_disk.py:0:0: implied-parameter-type-mismatch: Argument 'state' in argument_spec implies type as 'str' but documentation defines as 'string'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.name.typr: extra keys not allowed @ data['argument_spec']['name']['typr']. Got 'str'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.serial.typr: extra keys not allowed @ data['argument_spec']['serial']['typr']. Got 'str'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-documentation: DOCUMENTATION.options.state.type: not a valid value for dictionary value @ data['options']['state']['type']. Got 'string'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: parameter-invalid: Argument 'import-from' in argument_spec is not a valid python identifier
plugins/modules/cloud/misc/proxmox_disk.py:0:0: required_if-requirements-type: required_if must have third value (requirements) being a list or tuple; got type 'size'

The test ansible-test sanity --test validate-modules [explain] failed with 7 errors:

plugins/modules/cloud/misc/proxmox_disk.py:0:0: doc-required-mismatch: Argument 'action' in argument_spec is required, but is not documented as being required
plugins/modules/cloud/misc/proxmox_disk.py:0:0: implied-parameter-type-mismatch: Argument 'state' in argument_spec implies type as 'str' but documentation defines as 'string'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.name.typr: extra keys not allowed @ data['argument_spec']['name']['typr']. Got 'str'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.serial.typr: extra keys not allowed @ data['argument_spec']['serial']['typr']. Got 'str'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: invalid-documentation: DOCUMENTATION.options.state.type: not a valid value for dictionary value @ data['options']['state']['type']. Got 'string'
plugins/modules/cloud/misc/proxmox_disk.py:0:0: parameter-invalid: Argument 'import-from' in argument_spec is not a valid python identifier
plugins/modules/cloud/misc/proxmox_disk.py:0:0: required_if-requirements-type: required_if must have third value (requirements) being a list or tuple; got type 'size'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:57:161: E501: line too long (184 > 160 characters)

The test ansible-test sanity --test no-smart-quotes [explain] failed with 10 errors:

plugins/modules/cloud/misc/proxmox_disk.py:51:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:127:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:132:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:145:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:150:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:225:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:252:24: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:256:18: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:265:22: use ASCII quotes `'` and `"` instead of Unicode quotes
plugins/modules/cloud/misc/proxmox_disk.py:284:18: use ASCII quotes `'` and `"` instead of Unicode quotes

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:481:37: SyntaxError: config_str += f',{k}={v}'

click here for bot help

ansibullbot avatar Aug 09 '22 02:08 ansibullbot

Am I missing something, or are there no idempotency checks in this module? I always see changed=True returned (except in two special cases, where one is in an unexpected place).

felixfontein avatar Aug 18 '22 04:08 felixfontein

Am I missing something, or are there no idempotency checks in this module? I always see changed=True returned (except in two special cases, where one is in an unexpected place).

You are right, I will implement checks for idempotency.

castorsky avatar Aug 26 '22 13:08 castorsky

Plus sanity checks

russoz avatar Aug 27 '22 09:08 russoz

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: ansible-bad-module-import: Import external package or ansible.module_utils not ansible.errors

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/cloud/misc/proxmox_disk.py:65:34: W291: trailing whitespace
plugins/modules/cloud/misc/proxmox_disk.py:605:29: E203: whitespace before ':'

The test ansible-test sanity --test import --python 3.9 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.10 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/cloud/misc/proxmox_disk.py:65:34: W291: trailing whitespace
plugins/modules/cloud/misc/proxmox_disk.py:605:29: E203: whitespace before ':'

The test ansible-test sanity --test import --python 3.9 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.10 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/cloud/misc/proxmox_disk.py:65:34: W291: trailing whitespace
plugins/modules/cloud/misc/proxmox_disk.py:605:29: E203: whitespace before ':'

The test ansible-test sanity --test import --python 3.9 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.11 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.10 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: ansible-bad-module-import: Import external package or ansible.module_utils not ansible.errors

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/cloud/misc/proxmox_disk.py:65:34: W291: trailing whitespace
plugins/modules/cloud/misc/proxmox_disk.py:605:29: E203: whitespace before ':'

The test ansible-test sanity --test import --python 3.9 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: traceback: ImportError: import of "ansible.errors" is not allowed in this context

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: ansible-bad-module-import: Import external package or ansible.module_utils not ansible.errors

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:397:0: ansible-bad-module-import: Import external package or ansible.module_utils not ansible.errors

click here for bot help

ansibullbot avatar Aug 27 '22 10:08 ansibullbot

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:0:0: doc-choices-do-not-match-spec: Argument 'state' in argument_spec defines choices as (['present', 'resized', 'detached', 'moved', 'absent']) but documentation defines choices as (['present', 'updated', 'resized', 'detached', 'moved', 'absent'])

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:0:0: doc-choices-do-not-match-spec: Argument 'state' in argument_spec defines choices as (['present', 'resized', 'detached', 'moved', 'absent']) but documentation defines choices as (['present', 'updated', 'resized', 'detached', 'moved', 'absent'])

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:0:0: doc-choices-do-not-match-spec: Argument 'state' in argument_spec defines choices as (['present', 'resized', 'detached', 'moved', 'absent']) but documentation defines choices as (['present', 'updated', 'resized', 'detached', 'moved', 'absent'])

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/cloud/misc/proxmox_disk.py:0:0: doc-choices-do-not-match-spec: Argument 'state' in argument_spec defines choices as (['present', 'resized', 'detached', 'moved', 'absent']) but documentation defines choices as (['present', 'updated', 'resized', 'detached', 'moved', 'absent'])

click here for bot help

ansibullbot avatar Sep 12 '22 14:09 ansibullbot

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/7777b48c99c1a5ef5645fd42b8b50ab6182eef5d/pr-5101

Backported as https://github.com/ansible-collections/community.general/pull/5295

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Sep 18 '22 20:09 patchback[bot]

@castorsky thanks a lot for your contribution! @russoz thanks a lot for reviewing this!

felixfontein avatar Sep 18 '22 20:09 felixfontein