community.general icon indicating copy to clipboard operation
community.general copied to clipboard

Update zypper.py

Open spacemule opened this issue 1 year ago • 7 comments

add more checks for t-u

SUMMARY

Adds a few more files to check for to see if the target is using transactional updates. This is especially relevant for newly provisioned hosts that lack the file in /var/lib/misc.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zypper.py

ADDITIONAL INFORMATION

Provision a new MicroOS machine. Try to use the zypper module before any updates. It will fail. Add these checkes, and it will know to use t-u.

spacemule avatar Jul 13 '22 21:07 spacemule

cc @AnderEnder @alxgu @andytom @commel @dcermak @evrardjp @lrupp @sealor @toabctl click here for bot help

ansibullbot avatar Jul 13 '22 21:07 ansibullbot

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/packaging/os/zypper.py:515:12: E126: continuation line over-indented for hanging indent

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/packaging/os/zypper.py:515:12: E126: continuation line over-indented for hanging indent

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/packaging/os/zypper.py:515:12: E126: continuation line over-indented for hanging indent

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/packaging/os/zypper.py:515:12: E126: continuation line over-indented for hanging indent

click here for bot help

ansibullbot avatar Jul 13 '22 21:07 ansibullbot

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

I'll get to this shortly. :)

spacemule avatar Jul 26 '22 12:07 spacemule

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

github-actions[bot] avatar Jul 26 '22 12:07 github-actions[bot]

Hi @spacemule just a friendly reminder: don't forget to add the changelog fragment!

russoz avatar Aug 07 '22 09:08 russoz

@spacemule ping

needs_info

felixfontein avatar Sep 03 '22 10:09 felixfontein

@spacemule This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

ansibullbot avatar Oct 05 '22 11:10 ansibullbot

Please note that in #5461 the collection repository was restructured to remove the directory tree in plugins/modules/, and the corresponding tree in tests/unit/plugins/modules/. Your PR modifies files in this directory structure, and unfortunately now has some conflicts, potentially because of this. Please rebase with the current main branch to remove the conflicts.

felixfontein avatar Nov 03 '22 05:11 felixfontein

@spacemule You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help

ansibullbot avatar Nov 07 '22 05:11 ansibullbot