community.general icon indicating copy to clipboard operation
community.general copied to clipboard

Refactor term parsing for plugin.lookup.passwordstore

Open bergmannf opened this issue 3 years ago • 4 comments

SUMMARY

In #1681 it was discussed that lookup.plugin.passwordstore should not use the current way it is parsing the terms passed into the lookup plugin, but instead reuse the generic way implemented already.

For reference see: https://github.com/ansible-collections/community.general/pull/1681#discussion_r564653763 for the diskussion.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

passwordstore

ADDITIONAL INFORMATION

The feature would implement the term processing already used in other lookup plugins like hashi_vault (see https://github.com/ansible-collections/community.general/pull/23) and make the plugin behave in a similar way.

bergmannf avatar Jan 27 '21 15:01 bergmannf

Files identified in the description: None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibullbot avatar Jan 27 '21 15:01 ansibullbot

!component =plugins/lookup/passwordstore.py

bergmannf avatar Jan 27 '21 16:01 bergmannf

Hm I think i accidentally confused the bot, by referencing the issue in the PR that adds YAML support to the passwordstore - I'm not sure if simply removing the has_pr label is the way to go here, or if this should be done through the bot.

bergmannf avatar Jan 27 '21 16:01 bergmannf

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibullbot avatar Jan 27 '21 16:01 ansibullbot