community.general icon indicating copy to clipboard operation
community.general copied to clipboard

fix style in plugins

Open russoz opened this issue 4 months ago • 2 comments
trafficstars

SUMMARY

Fix style in filter, inventory and lookup

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/filter/replace_keys.py plugins/filter/to_prettytable.py plugins/inventory/cobbler.py plugins/inventory/gitlab_runners.py plugins/inventory/lxd.py plugins/inventory/nmap.py plugins/inventory/opennebula.py plugins/inventory/scaleway.py plugins/inventory/virtualbox.py plugins/inventory/xen_orchestra.py plugins/lookup/bitwarden.py plugins/lookup/cartesian.py plugins/lookup/chef_databag.py plugins/lookup/collection_version.py plugins/lookup/consul_kv.py plugins/lookup/credstash.py plugins/lookup/cyberarkpassword.py plugins/lookup/dig.py plugins/lookup/dnstxt.py plugins/lookup/etcd.py plugins/lookup/filetree.py plugins/lookup/flattened.py plugins/lookup/hiera.py plugins/lookup/keyring.py plugins/lookup/lastpass.py plugins/lookup/lmdb_kv.py plugins/lookup/merge_variables.py plugins/lookup/onepassword.py plugins/lookup/passwordstore.py plugins/lookup/random_pet.py plugins/lookup/random_string.py plugins/lookup/redis.py plugins/lookup/revbitspss.py plugins/lookup/shelvefile.py plugins/lookup/tss.py

russoz avatar Jun 26 '25 09:06 russoz

cc @Akasurde @None @RevBits @abarbare @alpex8 @azenk @conloos @dagwieers @ddelnano @delineaKrehl @feldsam @felixfontein @jparrill @jpmens @lungj @m-a-r-k-e @morph027 @opoplawski @remyleone @rlenferink @samdoran @shinuza @tgadiev @tylerezimmerman @vbotka click here for bot help

ansibullbot avatar Jun 26 '25 09:06 ansibullbot

If no one objects, I am planning on merging this by Monday or Tuesday

russoz avatar Jun 27 '25 23:06 russoz

Backport to stable-10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 329c2222fc19b422f2d37ec7bba2409949b273fb on top of patchback/backports/stable-10/329c2222fc19b422f2d37ec7bba2409949b273fb/pr-10303

Backporting merged PR #10303 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
    
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-10/329c2222fc19b422f2d37ec7bba2409949b273fb/pr-10303 upstream/stable-10
    
  4. Now, cherry-pick PR #10303 contents into that branch:
    $ git cherry-pick -x 329c2222fc19b422f2d37ec7bba2409949b273fb
    
    If it'll yell at you with something like fatal: Commit 329c2222fc19b422f2d37ec7bba2409949b273fb is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 329c2222fc19b422f2d37ec7bba2409949b273fb
    
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #10303 as close to the original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-10/329c2222fc19b422f2d37ec7bba2409949b273fb/pr-10303
    
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Jul 01 '25 13:07 patchback[bot]

Backport to stable-11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-11/329c2222fc19b422f2d37ec7bba2409949b273fb/pr-10303

Backported as https://github.com/ansible-collections/community.general/pull/10324

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Jul 01 '25 13:07 patchback[bot]

@russoz @remyleone @samdoran thanks!

felixfontein avatar Jul 01 '25 20:07 felixfontein