community.general
community.general copied to clipboard
ansible-collections
Fix for handling https URL link for firmware update
SUMMARY
ISSUE TYPE
- Bugfix Pull Request
- Docs Pull Request
- Feature Pull Request
- New Module/Plugin Pull Request
- Refactoring Pull Request
- Test Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
The test ansible-test sanity --test import --python 2.7 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ImportError: No module named requests
plugins/modules/wdc_redfish_command.py:204:0: traceback: ImportError: No module named requests (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ImportError: No module named requests (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.10 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.11 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.12 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.6 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.7 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.8 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.9 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test pep8 [explain] failed with 2 errors:
plugins/module_utils/wdc_redfish_utils.py:204:43: E128: continuation line under-indented for visual indent
plugins/module_utils/wdc_redfish_utils.py:326:9: E265: block comment should start with '# '
The test ansible-test sanity --test import --python 3.10 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.11 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.12 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.7 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.8 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.9 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test pep8 [explain] failed with 2 errors:
plugins/module_utils/wdc_redfish_utils.py:204:43: E128: continuation line under-indented for visual indent
plugins/module_utils/wdc_redfish_utils.py:326:9: E265: block comment should start with '# '
The test ansible-test sanity --test import --python 3.10 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.11 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.12 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.13 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.8 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.9 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test pep8 [explain] failed with 2 errors:
plugins/module_utils/wdc_redfish_utils.py:204:43: E128: continuation line under-indented for visual indent
plugins/module_utils/wdc_redfish_utils.py:326:9: E265: block comment should start with '# '
The test ansible-test sanity --test import --python 3.10 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.11 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.12 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.13 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.8 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test import --python 3.9 [explain] failed with 3 errors:
plugins/module_utils/wdc_redfish_utils.py:15:0: traceback: ModuleNotFoundError: No module named 'requests'
plugins/modules/wdc_redfish_command.py:204:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
plugins/modules/wdc_redfish_info.py:127:0: traceback: ModuleNotFoundError: No module named 'requests' (at plugins/module_utils/wdc_redfish_utils.py:15:0)
The test ansible-test sanity --test pep8 [explain] failed with 2 errors:
plugins/module_utils/wdc_redfish_utils.py:204:43: E128: continuation line under-indented for visual indent
plugins/module_utils/wdc_redfish_utils.py:326:9: E265: block comment should start with '# '
The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:
plugins/modules/wdc_redfish_command.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'requests''
plugins/modules/wdc_redfish_info.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'requests''
The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:
plugins/modules/wdc_redfish_command.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'requests''
plugins/modules/wdc_redfish_info.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'requests''
The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:
plugins/modules/wdc_redfish_command.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'requests''
plugins/modules/wdc_redfish_info.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'requests''
The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:
plugins/modules/wdc_redfish_command.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'requests''
plugins/modules/wdc_redfish_info.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'requests''
ping @vivaswatDev
needs_info
Hello Felix,
The https server we are using is trusted internal file server and self signed one. Hence we try to access the static file in that https server with Ansible's fetch_file() it fails with SSL verification error. We don't have any CA certified https server to cross verify whether fetch_file() works fine or not. I understand that request module is not permitted but my requirement is simple - i need to download a static firmware binary file from a self signed https server.
In theory you could use your own CA certificate and pass it with the ca_path option, but right now it's not possible to pass that on to fetch_file(), so it's not used for this request (https://github.com/ansible/ansible/issues/85172). What you could do is disable certificate checking altogether (which is currently the default, so should be the case if you didn't explicitly enable it).
hi @vivaswatDev thanks for your contribution. The PR template should have been filled, that information is actually used while processing the PR.
Also, please note that last month's comments are yet to be addressed.
needs_info
@vivaswatDev This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.
@vivaswatDev You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.