community.docker icon indicating copy to clipboard operation
community.docker copied to clipboard

Add sysctls option to docker_swarm_service

Open NairolfL opened this issue 2 months ago • 5 comments

SUMMARY

Add sysctls options to docker_swarm_service, as discussed in #190

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker_swarm_service

ADDITIONAL INFORMATION

NairolfL avatar Apr 17 '24 12:04 NairolfL

This is my first time contributing to this project. Don't hesitate to tell me if I'm missing something / doing something wrong.

NairolfL avatar Apr 17 '24 12:04 NairolfL

You also need to adjust the integration tests. You probably have to add sysctls: null to https://github.com/ansible-collections/community.docker/blob/main/tests/integration/targets/docker_swarm_service/vars/main.yml.

felixfontein avatar Apr 17 '24 17:04 felixfontein

Thank you for the feedback, I made the requested changes

NairolfL avatar Apr 22 '24 09:04 NairolfL

Thanks, looks good to me! If nobody objects, I'll merge this in ~a week.

felixfontein avatar Apr 22 '24 18:04 felixfontein

@NairolfL thanks for your contribution!

felixfontein avatar Apr 30 '24 20:04 felixfontein