community.crypto icon indicating copy to clipboard operation
community.crypto copied to clipboard

ecs_certificate: allow to request renewal without csr

Open francescolovecchio opened this issue 1 year ago • 3 comments

SUMMARY

See specification and module documentation

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ecs_certificate

ADDITIONAL INFORMATION

Renew certificate requests without csr failed with:

The csr field is required when request_type=renew

francescolovecchio avatar Apr 30 '24 14:04 francescolovecchio

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

felixfontein avatar Apr 30 '24 21:04 felixfontein

CC @ctrufan

felixfontein avatar Apr 30 '24 21:04 felixfontein

@felixfontein changelog fragment added! Thanks

francescolovecchio avatar Apr 30 '24 21:04 francescolovecchio

@sapnajainEntrust do you know whom to contact from Entrust's side to review this? @ctrufan doesn't seem to be active on GitHub anymore.

felixfontein avatar May 09 '24 15:05 felixfontein

Sorry about the delay. Looks good, thanks for the fixes!

ctrufan avatar May 09 '24 15:05 ctrufan

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/29ac3cbe8174be1e8a3177f588e29fa8eac182e0/pr-740

Backported as https://github.com/ansible-collections/community.crypto/pull/752

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar May 09 '24 18:05 patchback[bot]

@francescolovecchio thanks for this fix! @ctrufan thanks for reviewing! good to see you again :)

felixfontein avatar May 09 '24 18:05 felixfontein

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://ansible-collections.github.io/community.crypto/branch/main

github-actions[bot] avatar May 09 '24 18:05 github-actions[bot]