community.crypto
community.crypto copied to clipboard
ecs_certificate: allow to request renewal without csr
SUMMARY
See specification and module documentation
ISSUE TYPE
- Bugfix Pull Request
COMPONENT NAME
ecs_certificate
ADDITIONAL INFORMATION
Renew certificate requests without csr failed with:
The csr field is required when request_type=renew
Thanks for your contribution! Can you please add a changelog fragment? Thanks.
CC @ctrufan
@felixfontein changelog fragment added! Thanks
@sapnajainEntrust do you know whom to contact from Entrust's side to review this? @ctrufan doesn't seem to be active on GitHub anymore.
Sorry about the delay. Looks good, thanks for the fixes!
Backport to stable-1: 💚 backport PR created
✅ Backport PR branch: patchback/backports/stable-1/29ac3cbe8174be1e8a3177f588e29fa8eac182e0/pr-740
Backported as https://github.com/ansible-collections/community.crypto/pull/752
🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.
@francescolovecchio thanks for this fix! @ctrufan thanks for reviewing! good to see you again :)
Docs Build 📝
Thank you for contribution!✨
This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.crypto/branch/main