community.aws icon indicating copy to clipboard operation
community.aws copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

Add support for requesting public and private ACM certificate

Open sebastien-rosset opened this issue 2 years ago • 19 comments

SUMMARY
  1. Add new certificate_request parameter (and sub-options) to obtain a public or private cert from ACM.
  2. When certificate_request parameter is specified:
    1. Evaluate whether to create a new certificate request, renew or do nothing.
    2. Support public and private certs.
    3. Certificate request is submitted to ACM.
  3. Task output includes validation records, such as DNS CNAME records.
  4. Add wait and wait_timeout parameters. If wait is specified, wait until the validation records are generated, then return them.

Fixes #868

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_acm

ADDITIONAL INFORMATION
  1. Currently the aws_acm module only supports imported certificates. This PR is adding support for requesting a certificate.
  2. This PR should come after #870. To leverage the refactor work that was done in #870, I have rebased this PR from the acm-tags branch.
  3. The integration tests validate various scenarios for public certificates.
  4. Integration tests do not currently include validation of private certificates. This would require having another ansible module that can create/delete private certificate authorities. I.e. a pre-requisite for issuing private ACM certs is to have a private certificate authority. I would like to postpone these tests until such a module exist.

sebastien-rosset avatar Jan 15 '22 23:01 sebastien-rosset

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 16 '22 00:01 softwarefactory-project-zuul[bot]

Build succeeded.

softwarefactory-project-zuul[bot] avatar Jan 17 '22 05:01 softwarefactory-project-zuul[bot]

Build succeeded.

softwarefactory-project-zuul[bot] avatar Jan 17 '22 23:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 18 '22 00:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 18 '22 01:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 18 '22 02:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 18 '22 16:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 19 '22 00:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 19 '22 01:01 softwarefactory-project-zuul[bot]

Build succeeded.

softwarefactory-project-zuul[bot] avatar Jan 19 '22 02:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 19 '22 06:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 19 '22 21:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 21 '22 01:01 softwarefactory-project-zuul[bot]

@sebastien-rosset this PR contains the following merge commits:

  • https://github.com/ansible-collections/community.aws/commit/f9b4e94b9795368186b0bab35d790c7f9e47fd9f
  • https://github.com/ansible-collections/community.aws/commit/247dbc210e81be2cbd60b71e4341b32dbc8e9904
  • https://github.com/ansible-collections/community.aws/commit/f0994bd0ff92735174bae1b90298cc3f22e7bc4b
  • https://github.com/ansible-collections/community.aws/commit/feceacb7ebf265dc94af3d8a45f736ee8092013d

Please rebase your branch to remove these commits.

click here for bot help

ansibullbot avatar Jan 27 '22 23:01 ansibullbot

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 28 '22 00:01 softwarefactory-project-zuul[bot]

cc @jillr @markuman @matt-telstra @s-hertel @tremble click here for bot help

ansibullbot avatar Jan 28 '22 00:01 ansibullbot

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 28 '22 00:01 softwarefactory-project-zuul[bot]

Build failed.

softwarefactory-project-zuul[bot] avatar Jan 30 '22 15:01 softwarefactory-project-zuul[bot]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

softwarefactory-project-zuul[bot] avatar Mar 31 '22 14:03 softwarefactory-project-zuul[bot]