community.aws
community.aws copied to clipboard
Add secret manager replication support
Signed-off-by: Eric Millbrandt [email protected]
SUMMARY
Add support for regional secret replication. The component now supports:
- Creating a secret with a regional replica
- Adding a region replica to a secret
- Removing a region replica from a secret
ISSUE TYPE
- Feature Pull Request
COMPONENT NAME
aws_secret
ADDITIONAL INFORMATION
https://aws.amazon.com/about-aws/whats-new/2021/03/aws-secrets-manager-provides-support-to-replicate-secrets-in-aws-secrets-manager-to-multiple-aws-regions/ https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/secretsmanager.html
I like your suggestion. I will refactor to use the pattern you described.
I've added the backport-3 label as long as 4.0.0 is not released
cc @jillr @rrey @s-hertel @tremble click here for bot help
To try and get this moving again I've rebased and tweaked the tests.
Because CI only supports us-east-1 at this time I've commented out the CI tests. However, I have tested these locally.
Docs Build 📝
Thank you for contribution!✨
This PR has been merged and your docs changes will be incorporated when they are next published.
@emillbrandt-ngt Many thanks for taking the time to submit this PR, I'm sorry it's taken so long to get this merged.
No worries. Thanks for taking it!
Build succeeded (gate pipeline).
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 03s :heavy_check_mark: build-ansible-collection SUCCESS in 6m 02s :heavy_check_mark: ansible-test-sanity-docker-devel SUCCESS in 11m 42s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 10m 23s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 31s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 39s :heavy_check_mark: ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 35s :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 6m 36s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 8m 32s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 37s :heavy_check_mark: ansible-test-units-amazon-aws-python310 SUCCESS in 8m 01s :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 22s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 34s :heavy_check_mark: integration-community.aws-1 SUCCESS in 5m 27s :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :warning: integration-community.aws-19 SKIPPED :warning: integration-community.aws-20 SKIPPED :warning: integration-community.aws-21 SKIPPED :warning: integration-community.aws-22 SKIPPED
Backport to stable-5: 💚 backport PR created
✅ Backport PR branch: patchback/backports/stable-5/c7c68009080e4e28828ed435db02cdad83712ac6/pr-827
Backported as https://github.com/ansible-collections/community.aws/pull/1685
🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.