community.aws icon indicating copy to clipboard operation
community.aws copied to clipboard

Add tag support to ec2_placement_group

Open harisokanovic opened this issue 1 year ago • 10 comments
trafficstars

SUMMARY

Allows users to optionally create EC2 placement groups with tags. Extend integration suite with additional test cases.

ISSUE TYPE
  • Feature Pull Request

harisokanovic avatar Apr 23 '24 23:04 harisokanovic

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

github-actions[bot] avatar Apr 23 '24 23:04 github-actions[bot]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/3cfa2743cc274cfd89151ea892b56fbb

:x: ansible-galaxy-importer FAILURE in 5m 46s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 14m 54s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 44s :heavy_check_mark: integration-community.aws-1 SUCCESS in 7m 55s Skipped 21 jobs

@harisokanovic Thanks for your contribution. We'll also need a changelog fragment. Otherwise, LGTM.

markuman avatar Jun 13 '24 17:06 markuman

@harisokanovic Thanks for your contribution. We'll also need a changelog fragment. Otherwise, LGTM.

Hi Markus, thanks for looking it over. I pushed an updated branch with your suggestions and a changelog fragment.

harisokanovic avatar Jun 14 '24 00:06 harisokanovic

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/ee566acb948c44f4b7b4924957840a3d

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 08s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 52s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 17s :heavy_check_mark: integration-community.aws-1 SUCCESS in 10m 37s Skipped 21 jobs

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/0ec61a12dbcc469482294a970a2b00bb

:x: ansible-galaxy-importer FAILURE in 4m 53s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 58s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 14s :heavy_check_mark: integration-community.aws-1 SUCCESS in 5m 48s Skipped 21 jobs

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/0a753632fc0e47cbabc38f957a4d9507

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 9m 51s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 52s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 38s :heavy_check_mark: integration-community.aws-1 SUCCESS in 9m 20s Skipped 21 jobs

Hi @tremble @markuman, I believe all feedback was addressed in the latest update, and the bots now appear happy. Please let me know if I missed anything.

harisokanovic avatar Jun 17 '24 22:06 harisokanovic

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/3ef7f7f0064f428283b4b67f198b598b

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 57s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 52s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 16s :heavy_check_mark: integration-community.aws-1 SUCCESS in 10m 00s Skipped 21 jobs

Two tests failed with this doc error:

ERROR: Found 1 validate-modules issue(s) which need to be resolved:
ERROR: plugins/inventory/aws_mq.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None

I don't think it's related to my changes since I did not edit aws_mq.py. Any suggestions on how to clear this up?

harisokanovic avatar Jul 03 '24 15:07 harisokanovic

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/269c4e8208664695abcd24ac132514d5

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 18s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 10m 32s :heavy_check_mark: ansible-test-splitter SUCCESS in 4m 24s :heavy_check_mark: integration-community.aws-1 SUCCESS in 5m 34s Skipped 21 jobs

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/0dc9b23c9add47919c8876fe2c90391e

:x: ansible-galaxy-importer FAILURE in 4m 49s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 10m 30s :heavy_check_mark: ansible-test-splitter SUCCESS in 4m 14s :heavy_check_mark: integration-community.aws-1 SUCCESS in 7m 24s Skipped 21 jobs

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/c235bd33fd7676aabf71ff928fb3d59d96c9f157/pr-2081

Backported as https://github.com/ansible-collections/community.aws/pull/2132

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Aug 01 '24 06:08 patchback[bot]