community.aws Add ResourceType on ec2 snapshot copy

SUMMARY

Fixes this issue that shows up when tags are specified:

An error occurred waiting for the snapshot to become available.: An
error occurred (InvalidParameterValue) when calling the CopySnapshot
operation: Tag specification resource type must have a value

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_snapshot_copy

ADDITIONAL INFORMATION

# before

botocore.exceptions.ClientError: An error occurred (InvalidParameterValue) when calling the CopySnapshot operation: Tag specification resource type must have a value                              
fatal: [localhost]: FAILED! => {                                                                                                                                                                   
    "boto3_version": "1.24.57",                                                                                                                                                                    
    "botocore_version": "1.27.58",                                                                                                                                                                 
    "changed": false,                                                                                                                                                                              
    "error": {                                                                                                                                                                                     
        "code": "InvalidParameterValue",                                                                                                                                                           
        "message": "Tag specification resource type must have a value"                                                                                                                             
    },  
....


# after  (no error message)

changed: [localhost] => {                                                                                                                                                                          
    "changed": true,                                                                                                                                                                               
    "invocation": {                                                                                                                                                                                
        "module_args": {       
.....

Aug 24 '22 16:08 bplaxco

cc @Deepakkothandan @jillr @markuman @s-hertel @tremble click here for bot help

Aug 24 '22 16:08 ansibullbot

Build succeeded.

Aug 24 '22 16:08 softwarefactory-project-zuul[bot]

Changelog fragment added.

Looking into the tests.

Sep 02 '22 16:09 bplaxco

Build succeeded.

Sep 02 '22 17:09 softwarefactory-project-zuul[bot]

Build failed.

Sep 02 '22 18:09 softwarefactory-project-zuul[bot]

Build failed.

Sep 02 '22 18:09 softwarefactory-project-zuul[bot]

@tremble in the zuul ouput I get:

    "error": {
        "code": "UnauthorizedOperation",
        "message": "You are not authorized to perform this operation. Encoded authorization failure message: SZOho26QkeN31KcOxBTUnC_sBSeRa3G9qqAmqJOLtkkAiUvLcOIlJVojSNLkyZa7MXEHWbTOAtc5aemsWR_tKiqEZtwr5OlwXk4PbtKTtj0NdpDaBeDs1q-Mpt7zDktDjJmk41tSPe-Rjjqe1ftFJhuZ76rQKHOXEeLol1QsaW2kA9x74EEf6gbr13kMUi2CyF3D-XTFMLkpZj-XShxzE9QbF1xvmnvwxIbmwuVk0PWFUX8dKbQbeB4K_jSCBLIV5Ag3Rio0Foc4h6uYfBmTz_vOR7J2ukyrRdgn5dwIc_78jFpa2DSqPa93EbGXeXjW6fTtzFvsExeRynD7-QBDY4iZEYGE2inBGZHZO7elmhh4Ie9G-xV6g2hBZVlWShrDzxGoJjanOiqTxl3530TxVRO-YO3kIzDbG55DouvtyOGdJyQntxyeIB2eR0gZhI5maCAcsD2YODtRyhwIDIXhGiBKmB4GmZ90ZgfQ0zHkLf4aLr5xxZcpeqf3juVUpMUMdOIWQ_VIdldVmPvx13e4FrsVACt4509Uh1vt5R7N-vX6YSh5g9CDrJ8"
    }

The module args passed in to ec2_snapshot_copy seem legit from what I know about the module, would someone be able to take a look and confirm the service account used has the right permissions? Or would you rather me mark the tests as disabled or something like that?

Sep 02 '22 18:09 bplaxco

@tremble

I went ahead and removed the tests to get the MR through since they were marked as optional, but since they seemed to be failing because of a permission issue with the service account running them, I kept them in the history[1] in case we want to pull them back in.

Feel free to ping me on gchat at work if you'd like to sync up on getting the test running ^_^

[1] The tests are still on aec7b2fd397337fced67d9b4846fbeed74db61cc

Sep 14 '22 22:09 bplaxco

Build succeeded.

Sep 14 '22 22:09 softwarefactory-project-zuul[bot]

Hey @tremble just wanted to see if you need anything else from me on this ^_^

Nov 08 '22 19:11 bplaxco

@bplaxco sorry about the delay here. LGTM

Nov 25 '22 11:11 tremble

Build succeeded (gate pipeline).

Nov 25 '22 11:11 softwarefactory-project-zuul[bot]

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/fad358924d91150b6278a7832c2f2028d588bd44/pr-1419

Backported as https://github.com/ansible-collections/community.aws/pull/1605

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

Nov 25 '22 11:11 patchback[bot]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Nov 25 '22 11:11 github-actions[bot]

community.aws community.aws copied to clipboard

Add ResourceType on ec2 snapshot copy

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Backport to stable-5: 💚 backport PR created

Docs Build 📝

community.aws
community.aws copied to clipboard