community.aws icon indicating copy to clipboard operation
community.aws copied to clipboard

New Module - eks_nodegroup

Open tjarra opened this issue 2 years ago • 8 comments

SUMMARY

Add a new module to manage nodegroups in EKS clusters.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

eks_nodegroup

ADDITIONAL INFORMATION

TODO:

- name: create nodegroup
  community.aws.eks_nodegroup:
    name: test_nodegroup
    state: present
    cluster_name: test_cluster
    node_role: arn:aws:eks:us-east-1:1231231123:role/asdf
    subnets:
      - subnet-qwerty123
      - subnet-asdfg456
    scaling_config:
      - min_size: 1
      - max_size: 2
      - desired_size: 1
    disk_size: 20
    instance_types: 't3.micro'
    ami_type: 'AL2_x86_64'
    labels:
      - 'teste': 'test'
    taints:
      - key: 'test'
        value: 'test'
        effect: 'NO_SCHEDULE'
    capacity_type: 'on_demand'

tjarra avatar Aug 18 '22 12:08 tjarra

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

github-actions[bot] avatar Aug 18 '22 12:08 github-actions[bot]

cc @jillr @markuman @s-hertel @tremble click here for bot help

ansibullbot avatar Aug 18 '22 12:08 ansibullbot

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 15s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 00s :x: ansible-test-sanity-docker-devel FAILURE in 10m 41s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 10m 32s :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 31s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 49s :heavy_check_mark: ansible-test-units-community-aws-python38 SUCCESS in 6m 00s :heavy_check_mark: ansible-test-units-community-aws-python39 SUCCESS in 6m 53s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 29s :warning: integration-community.aws-1 SKIPPED :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 10s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 49s :x: ansible-test-sanity-docker-devel FAILURE in 9m 26s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 10m 33s :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 28s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 11s :heavy_check_mark: ansible-test-units-community-aws-python38 SUCCESS in 5m 45s :heavy_check_mark: ansible-test-units-community-aws-python39 SUCCESS in 6m 47s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 40s :warning: integration-community.aws-1 SKIPPED :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED

The permissions for CI should now be set, but I had a difficult time getting this test suite to pass. It just takes too long. My suggestion would be to try being more economical in what is being tested if possible, and only use wait: True in cases where it is absolutely necessary. Also, this PR will need an alias file for the test target in order for the tests to run.

gravesm avatar Oct 03 '22 15:10 gravesm

Thanks for the feedback @gravesm Yeah, i also think it's taking too long to run, i will review the tests to reduce the time and add the alias.

tjarra avatar Oct 10 '22 17:10 tjarra

Build failed.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 41s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 31s :x: ansible-test-sanity-docker-devel FAILURE in 9m 37s (non-voting) :x: ansible-test-sanity-docker-milestone FAILURE in 10m 13s :x: ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 41s :x: ansible-test-sanity-docker-stable-2.13 FAILURE in 10m 08s :x: ansible-test-sanity-docker-stable-2.14 FAILURE in 8m 55s (non-voting) :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 7m 33s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 6m 38s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 22s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 38s :x: integration-community.aws-1 TIMED_OUT in 1h 00m 43s :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 32s

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 31s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 04s :x: ansible-test-sanity-docker-devel FAILURE in 10m 29s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 8m 49s :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 14s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 39s :x: ansible-test-sanity-docker-stable-2.14 FAILURE in 9m 15s (non-voting) :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 7m 01s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 7m 08s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 43s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 48s :heavy_check_mark: integration-community.aws-1 SUCCESS in 25m 42s :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 20s

Build failed.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 23s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 05s :x: ansible-test-sanity-docker-devel FAILURE in 11m 37s (non-voting) :x: ansible-test-sanity-docker-milestone FAILURE in 9m 49s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 54s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 26s :x: ansible-test-sanity-docker-stable-2.14 FAILURE in 10m 04s :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 7m 58s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 8m 05s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 48s :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 12s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 23s :heavy_check_mark: integration-community.aws-1 SUCCESS in 27m 33s :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :warning: integration-community.aws-19 SKIPPED :warning: integration-community.aws-20 SKIPPED :warning: integration-community.aws-21 SKIPPED :warning: integration-community.aws-22 SKIPPED

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 07s :heavy_check_mark: build-ansible-collection SUCCESS in 6m 43s :x: ansible-test-sanity-docker-devel FAILURE in 12m 28s (non-voting) :x: ansible-test-sanity-docker-milestone FAILURE in 9m 14s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 52s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 59s :heavy_check_mark: ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 14s :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 6m 11s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 5m 55s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 5m 41s :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 26s :heavy_check_mark: ansible-test-splitter SUCCESS in 4m 11s :heavy_check_mark: integration-community.aws-1 SUCCESS in 25m 32s :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :warning: integration-community.aws-19 SKIPPED :warning: integration-community.aws-20 SKIPPED :warning: integration-community.aws-21 SKIPPED :warning: integration-community.aws-22 SKIPPED

This is super useful! Brilliant work! Is there anything we can do to help get this merged / released?

filipecifali avatar Jan 24 '23 12:01 filipecifali

Build succeeded (gate pipeline).

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 32s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 49s :x: ansible-test-sanity-docker-devel FAILURE in 10m 18s (non-voting) :x: ansible-test-sanity-docker-milestone FAILURE in 8m 49s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 05s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 34s :heavy_check_mark: ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 48s :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 5m 56s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 7m 29s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 5m 33s :heavy_check_mark: ansible-test-units-amazon-aws-python310 SUCCESS in 6m 21s :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 08s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 25s :heavy_check_mark: integration-community.aws-1 SUCCESS in 24m 41s :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :warning: integration-community.aws-19 SKIPPED :warning: integration-community.aws-20 SKIPPED :warning: integration-community.aws-21 SKIPPED :warning: integration-community.aws-22 SKIPPED

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/3f37c9758777b76afa8ba50fc9dfd64dc31fcff7/pr-1415

Backported as https://github.com/ansible-collections/community.aws/pull/1702

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Feb 03 '23 15:02 patchback[bot]

Hi all,

Sorry this has taken so long to get merged. This should be available once we release 5.3.0

@tjarra Many thanks for your work here.

tremble avatar Feb 03 '23 15:02 tremble