community.aws Minor linting fixups

Minor linting fixups - 2022-08-12

Open tremble opened this issue 1 year ago • 3 comments

SUMMARY

Various linting and unit test fixups

unused variables
overly broad Exception catching (highlighted some broken tests)
removes direct use of unittest in favour of pytest (see also https://github.com/ansible-collections/amazon.aws/pull/961)
cleans up skipping of tests when botocore/boto3 aren't installed
passes error message from VPNConnectionException into its super to make testing easier, should never be directly exposed to the user

Removes tests for 3 modules which now have integration tests, they're either recording based (fragile)or test things which are separately tested in the integration tests.

lambda
s3_bucket_notifications
route53_zone

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

plugins/modules/ec2_vpc_vpn.py tests/unit

ADDITIONAL INFORMATION

Aug 12 '22 07:08 tremble

cc @jillr @markuman @s-hertel click here for bot help

Aug 12 '22 07:08 ansibullbot

Build succeeded.

Aug 12 '22 07:08 softwarefactory-project-zuul[bot]

Build succeeded.

Aug 12 '22 10:08 softwarefactory-project-zuul[bot]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Aug 17 '22 09:08 github-actions[bot]

@tremble I guess the dict error originates from https://github.com/ansible-collections/community.aws/blob/main/plugins/modules/lambda_event.py#L66

Aug 17 '22 09:08 alinabuzachis

Build succeeded.

Aug 17 '22 10:08 softwarefactory-project-zuul[bot]

cc @pjodouin @ryansb click here for bot help

Aug 17 '22 10:08 ansibullbot

Build succeeded.

Aug 17 '22 11:08 softwarefactory-project-zuul[bot]

@alinabuzachis Fixed that docs error

Aug 17 '22 13:08 tremble

Build succeeded (gate pipeline).

Aug 17 '22 18:08 softwarefactory-project-zuul[bot]

Backport to stable-4: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 8b4afa93b78ea293e3c5c68fc43bb0fc301ed183 on top of patchback/backports/stable-4/8b4afa93b78ea293e3c5c68fc43bb0fc301ed183/pr-1408

Backporting merged PR #1408 into main

Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/community.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-4/8b4afa93b78ea293e3c5c68fc43bb0fc301ed183/pr-1408 upstream/stable-4

Now, cherry-pick PR #1408 contents into that branch:
```
$ git cherry-pick -x 8b4afa93b78ea293e3c5c68fc43bb0fc301ed183
```
If it'll yell at you with something like fatal: Commit 8b4afa93b78ea293e3c5c68fc43bb0fc301ed183 is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x 8b4afa93b78ea293e3c5c68fc43bb0fc301ed183
```
At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #1408 as close to the original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-4/8b4afa93b78ea293e3c5c68fc43bb0fc301ed183/pr-1408

Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

Sep 09 '22 09:09 patchback[bot]

community.aws community.aws copied to clipboard

Minor linting fixups - 2022-08-12

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Docs Build 📝

Backport to stable-4: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1408 into main

community.aws
community.aws copied to clipboard