azure
azure copied to clipboard
ansible-collections
Allow creating gallery image versions from storage accounts
SUMMARY
It's possible to upload a VHD into a container in a storage account and then use that to import an image version. This adds a third way to specify an os_disk in the galleryimageversion plugin to support that approach.
ISSUE TYPE
- Feature Pull Request
COMPONENT NAME
galleryimageversion
Hi, thanks for the review!
I attempted to address the style comments. If it's still not looking right, is there a style guide for the project I should follow, or a linter? I did my best to follow the existing style of the file.
I think this should be ready for a re-review (time permitting, of course). We're using this in some automation in Fedora so I'd love it to be in the next release if possible. Thanks!
Hi @Fred-sun,
Just wanted to check in if there's anything I can do to help move this along - we've been carrying this patch to upload Fedora images nightly for a couple months and it's been working fine, for what it's worth.
@jeremycline Is the location of your test case improperly arranged? It is between line 307 and 387. Should we create a new name of galleryimageversion?
@jeremycline In addition, after the completion of the test, please delete the newly created galleryimage, otherwise there will be problems when deleting the gallery. Thank you!
Thanks for the review!
I've given the image version a different name and ensured it's deleted with the other image version.
@jeremycline Thanks for your update! I will recheck it and push for merged!