Fix wrong direction of XML deserialization.

[sfuhrm]

SUMMARY

Fixes wrong direction of module restconf_get's wrong direction of XML deserialization.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

restconf_get

ADDITIONAL INFORMATION

The original implementation tried to serialize a dict towards a XML-string, not deserialize a XML-format string towards an dict:

fatal: [XXXX]: FAILED! => changed=false 
  msg: |-
    'xmltodict' returned the following error when converting     <interfaces xmlns="http://openconfig.net/yang/interfaces">
...
...
        </interfaces>
     to xml. 'str' object has no attribute 'items'

In fact the code is calling dict_to_xml(), not xml_to_dict() as expected.

Tested the bugfix with a Nexus 9300v NXOS v9.3.10 device.

[softwarefactory-project-zuul[bot]]

Build failed.

:heavy_check_mark: ansible-changelog-fragment SUCCESS in 24s :x: ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 9m 39s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 20m 56s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-netconf-python38-stable212 SUCCESS in 1h 14m 26s :x: ansible-test-network-integration-junos-vsrx-netconf-python38 RETRY_LIMIT in 5m 22s :x: ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 10m 15s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 14m 03s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-python38-stable212 SUCCESS in 11m 50s :x: ansible-test-network-integration-junos-vsrx-network_cli-python38 RETRY_LIMIT in 6m 24s :x: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 9m 49s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 12m 24s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python38-stable212 SUCCESS in 11m 43s :x: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python38 RETRY_LIMIT in 8m 59s :x: ansible-ee-integration-cisco-nxos-cli-python39-latest FAILURE in 2h 24m 05s (non-voting) :heavy_check_mark: ansible-ee-integration-arista-eos-latest SUCCESS in 1h 09m 39s :heavy_check_mark: ansible-ee-integration-arista-eos-stable-2.9 SUCCESS in 1h 02m 48s :heavy_check_mark: ansible-ee-integration-arista-eos-stable-2.11 SUCCESS in 1h 08m 32s :heavy_check_mark: ansible-ee-integration-arista-eos-stable-2.12 SUCCESS in 1h 09m 11s :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-latest SUCCESS in 43m 32s :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-stable-2.9 SUCCESS in 38m 21s (non-voting) :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-stable-2.11 SUCCESS in 43m 20s :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-stable-2.12 SUCCESS in 43m 28s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-latest SUCCESS in 1h 13m 30s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-stable-2.9 SUCCESS in 1h 05m 00s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-stable-2.11 SUCCESS in 1h 13m 27s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-stable-2.12 SUCCESS in 1h 13m 58s :x: ansible-ee-integration-ios-latest FAILURE in 13m 51s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 FAILURE in 16m 11s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 15m 17s (non-voting) :x: ansible-ee-integration-ios-libssh-latest FAILURE in 57m 28s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 52m 26s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 58m 49s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 57m 20s (non-voting) :heavy_check_mark: ansible-ee-integration-vyos-latest SUCCESS in 1h 07m 46s :heavy_check_mark: ansible-ee-integration-vyos-libssh-latest SUCCESS in 1h 09m 52s :heavy_check_mark: build-ansible-collection SUCCESS in 6m 28s :x: ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python38 RETRY_LIMIT in 5m 44s :heavy_check_mark: ansible-tox-linters SUCCESS in 5m 46s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 13s

[softwarefactory-project-zuul[bot]]

Build failed.

:heavy_check_mark: ansible-changelog-fragment SUCCESS in 17s :x: ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 9m 18s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 21m 36s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-netconf-python38-stable212 SUCCESS in 1h 35m 06s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-netconf-python39 SUCCESS in 1h 15m 58s :x: ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 8m 48s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 12m 15s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-python38-stable212 SUCCESS in 11m 38s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-python39 SUCCESS in 12m 04s :x: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 11m 37s (non-voting) :x: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 FAILURE in 10m 21s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python38-stable212 SUCCESS in 11m 40s :x: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 FAILURE in 10m 10s :heavy_check_mark: ansible-ee-integration-cisco-nxos-cli-python39-latest SUCCESS in 2h 23m 40s (non-voting) :heavy_check_mark: ansible-ee-integration-arista-eos-latest SUCCESS in 1h 17m 26s :heavy_check_mark: ansible-ee-integration-arista-eos-stable-2.9 SUCCESS in 1h 05m 45s :heavy_check_mark: ansible-ee-integration-arista-eos-stable-2.11 SUCCESS in 1h 12m 26s :x: ansible-ee-integration-arista-eos-stable-2.12 POST_FAILURE in 1h 15m 23s :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-latest SUCCESS in 47m 15s :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-stable-2.9 SUCCESS in 41m 57s (non-voting) :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-stable-2.11 SUCCESS in 47m 00s :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-stable-2.12 SUCCESS in 45m 43s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-latest SUCCESS in 1h 17m 06s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-stable-2.9 SUCCESS in 1h 07m 58s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-stable-2.11 SUCCESS in 1h 15m 55s :x: ansible-ee-integration-arista-eos-libssh-stable-2.12 POST_FAILURE in 1h 17m 44s :x: ansible-ee-integration-ios-latest FAILURE in 14m 13s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 12s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 37s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 46s (non-voting) :x: ansible-ee-integration-ios-libssh-latest FAILURE in 57m 47s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 51m 52s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 57m 05s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 57m 40s (non-voting) :heavy_check_mark: ansible-ee-integration-vyos-latest SUCCESS in 1h 10m 00s :heavy_check_mark: ansible-ee-integration-vyos-libssh-latest SUCCESS in 1h 12m 15s :heavy_check_mark: build-ansible-collection SUCCESS in 6m 04s :heavy_check_mark: ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 SUCCESS in 13m 09s :heavy_check_mark: ansible-tox-linters SUCCESS in 5m 34s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 24s

[softwarefactory-project-zuul[bot]]

Build failed.

:heavy_check_mark: ansible-changelog-fragment SUCCESS in 21s :x: ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 9m 14s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 12m 50s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 02m 11s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-netconf-python39 SUCCESS in 1h 03m 12s :x: ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 8m 26s (non-voting) :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 11m 57s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 12m 47s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-python39 SUCCESS in 11m 35s :x: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 9m 35s (non-voting) :x: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 FAILURE in 10m 00s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 11m 29s :heavy_check_mark: ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 SUCCESS in 12m 39s :heavy_check_mark: ansible-ee-integration-cisco-nxos-cli-python39-latest SUCCESS in 2h 09m 19s (non-voting) :heavy_check_mark: ansible-ee-integration-arista-eos-latest SUCCESS in 1h 01m 34s :heavy_check_mark: ansible-ee-integration-arista-eos-stable-2.9 SUCCESS in 55m 36s :heavy_check_mark: ansible-ee-integration-arista-eos-stable-2.11 SUCCESS in 1h 01m 57s :heavy_check_mark: ansible-ee-integration-arista-eos-stable-2.12 SUCCESS in 1h 01m 38s :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-latest SUCCESS in 39m 40s :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-stable-2.9 SUCCESS in 34m 54s (non-voting) :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-stable-2.11 SUCCESS in 39m 28s :heavy_check_mark: ansible-ee-integration-arista-eos-httpapi-stable-2.12 SUCCESS in 40m 15s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-latest SUCCESS in 1h 06m 03s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-stable-2.9 SUCCESS in 57m 31s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-stable-2.11 SUCCESS in 1h 05m 32s :heavy_check_mark: ansible-ee-integration-arista-eos-libssh-stable-2.12 SUCCESS in 1h 05m 55s :x: ansible-ee-integration-ios-latest FAILURE in 14m 19s (non-voting) :x: ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 10s (non-voting) :x: ansible-ee-integration-ios-stable-2.11 FAILURE in 12m 59s (non-voting) :x: ansible-ee-integration-ios-stable-2.12 FAILURE in 13m 35s (non-voting) :x: ansible-ee-integration-ios-libssh-latest FAILURE in 52m 28s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.9 NODE_FAILURE in 0s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 52m 53s (non-voting) :x: ansible-ee-integration-ios-libssh-stable-2.12 NODE_FAILURE in 0s (non-voting) :heavy_check_mark: ansible-ee-integration-vyos-latest SUCCESS in 1h 03m 06s :heavy_check_mark: ansible-ee-integration-vyos-libssh-latest SUCCESS in 1h 04m 58s :heavy_check_mark: build-ansible-collection SUCCESS in 6m 09s :heavy_check_mark: ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 SUCCESS in 9m 23s :heavy_check_mark: ansible-tox-linters SUCCESS in 5m 27s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 42s