[PR #954 backport][stable-4] Minor Linting fixups - 2022-08-05

[tremble]

Manual backport of #954

SUMMARY

Minor linting fixups

• docs linting and cleanup
• unused variables
• unused import
• "mutually_exclusive" which was accidentally dropped on the floor.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

plugins/modules/cloudformation.py plugins/modules/ec2_eni.py plugins/modules/ec2_eni_info.py plugins/modules/ec2_instance.py plugins/modules/ec2_security_group.py plugins/modules/ec2_vol.py plugins/modules/ec2_vol_info.py plugins/modules/ec2_vpc_dhcp_option.py plugins/modules/ec2_vpc_net.py plugins/modules/ec2_vpc_subnet.py plugins/modules/elb_classic_lb.py plugins/modules/s3_bucket.py plugins/modules/s3_object.py

ADDITIONAL INFORMATION

Removes some documentation references to old "versions", these were Ansible versions which are long out of support. CloudFormations module previously talked about keeping boto3 and botocore up to date. Now that we have an official policy around supported versions this is no longer as relevant and the module itself is no longer changing as fast.

Reviewed-by: Gonéri Le Bouder

[ansibullbot]

cc @abikouo @adq @alinabuzachis @brandond @healem @jillr @joelthompson @jsdalton @jsmartin @lwade @s-hertel click here for bot help

[github-actions[bot]]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

[softwarefactory-project-zuul[bot]]

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 23s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 21s :heavy_check_mark: ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 21s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 20s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 46s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 5m 35s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 06s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 32s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 15m 19s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 41m 18s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 26m 38s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 32m 22s :warning: integration-amazon.aws-5 SKIPPED :warning: integration-amazon.aws-6 SKIPPED :warning: integration-amazon.aws-7 SKIPPED :warning: integration-amazon.aws-8 SKIPPED :warning: integration-amazon.aws-9 SKIPPED :warning: integration-amazon.aws-10 SKIPPED :warning: integration-amazon.aws-11 SKIPPED :warning: integration-amazon.aws-12 SKIPPED :warning: integration-amazon.aws-13 SKIPPED :warning: integration-community.aws-1 SKIPPED :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED

[softwarefactory-project-zuul[bot]]

Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 40s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 59s :heavy_check_mark: ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 50s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 16s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 49s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 6m 21s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 19s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 32s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 12m 21s :x: integration-amazon.aws-2 TIMED_OUT in 1h 00m 45s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 21m 10s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 28m 13s :warning: integration-amazon.aws-5 SKIPPED :warning: integration-amazon.aws-6 SKIPPED :warning: integration-amazon.aws-7 SKIPPED :warning: integration-amazon.aws-8 SKIPPED :warning: integration-amazon.aws-9 SKIPPED :warning: integration-amazon.aws-10 SKIPPED :warning: integration-amazon.aws-11 SKIPPED :warning: integration-amazon.aws-12 SKIPPED :warning: integration-amazon.aws-13 SKIPPED :heavy_check_mark: integration-community.aws-1 SUCCESS in 5m 52s :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 11s

[tremble]

regate

[softwarefactory-project-zuul[bot]]

Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 57s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 02s :heavy_check_mark: ansible-test-sanity-aws-ansible-python38 SUCCESS in 7m 59s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 50s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 36s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 6m 57s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 5m 46s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 34s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 12m 11s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 35m 18s :x: integration-amazon.aws-3 FAILURE in 17m 19s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 33m 31s :warning: integration-amazon.aws-5 SKIPPED :warning: integration-amazon.aws-6 SKIPPED :warning: integration-amazon.aws-7 SKIPPED :warning: integration-amazon.aws-8 SKIPPED :warning: integration-amazon.aws-9 SKIPPED :warning: integration-amazon.aws-10 SKIPPED :warning: integration-amazon.aws-11 SKIPPED :warning: integration-amazon.aws-12 SKIPPED :warning: integration-amazon.aws-13 SKIPPED :heavy_check_mark: integration-community.aws-1 SUCCESS in 5m 13s :heavy_check_mark: integration-community.aws-2 SUCCESS in 20m 00s :heavy_check_mark: integration-community.aws-3 SUCCESS in 8m 41s :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 16s

[alinabuzachis]

regate

[softwarefactory-project-zuul[bot]]

Build succeeded (gate pipeline).

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 12s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 21s :heavy_check_mark: ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 04s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 43s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 20s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 7m 04s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 20s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 40s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 12m 27s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 32m 32s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 20m 41s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 28m 00s :warning: integration-amazon.aws-5 SKIPPED :warning: integration-amazon.aws-6 SKIPPED :warning: integration-amazon.aws-7 SKIPPED :warning: integration-amazon.aws-8 SKIPPED :warning: integration-amazon.aws-9 SKIPPED :warning: integration-amazon.aws-10 SKIPPED :warning: integration-amazon.aws-11 SKIPPED :warning: integration-amazon.aws-12 SKIPPED :warning: integration-amazon.aws-13 SKIPPED :warning: integration-community.aws-1 SKIPPED :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 18s