amazon.aws icon indicating copy to clipboard operation
amazon.aws copied to clipboard

iam_role_info - fix bug in prefix_path handling of missing /s

Open tremble opened this issue 1 year ago • 2 comments

SUMMARY

fixes: #2065

When updating the code in iam_role_info to handle missing / at the start/end of prefix_path, the string as finally built should be an f-string not a simple string/

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iam_role_info

ADDITIONAL INFORMATION

Thanks for @vonschultz for catching this one.

tremble avatar Apr 29 '24 07:04 tremble

@vonschultz many thanks for catching this and tracking down the cause, I'm guessing 7.5.0 caused something to break for you for which I apologise.

In future, if the original PR has already been merged it's a better idea to open a new issue, rather than review a merged PR. It's very easy to miss comments on an old merged PR, if I happened to have marked the notification email as read your review would be almost impossible to spot.

tremble avatar Apr 29 '24 07:04 tremble

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/3db7c72e7795477c8393532ea9fe9a4e

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 29s :heavy_check_mark: build-ansible-collection SUCCESS in 15m 44s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 27s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 5m 14s Skipped 43 jobs

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/ece121bbf91f4b31956abf107e3d985f

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 30s :heavy_check_mark: build-ansible-collection SUCCESS in 16m 17s :heavy_check_mark: ansible-test-splitter SUCCESS in 8m 31s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 6m 18s Skipped 43 jobs

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/a92f03ad14ee3482120d0a21a00d79b7f07d3610/pr-2066

Backported as https://github.com/ansible-collections/amazon.aws/pull/2069

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Apr 30 '24 11:04 patchback[bot]