Add Object Lock default retention configuration for S3 buckets

[abraverm]

SUMMARY

https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-configure.html#object-lock-configure-set-retention-period-object

Design detail: AWS API doesn't support unsetting the default retention, though it is possible in the Web console.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

s3_bucket

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging github.com/ansible-collections/amazon.aws for 2062,95fca997730df9369056aae41d066da020afe7f4

[github-actions[bot]]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

[softwarefactory-project-zuul[bot]]

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/8af8636d02ec441d954236ae61c6ceda

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 54s :heavy_check_mark: build-ansible-collection SUCCESS in 16m 15s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 30s :x: integration-amazon.aws-1 FAILURE in 7m 42s Skipped 43 jobs

[softwarefactory-project-zuul[bot]]

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/57d1a884ecc14296b33dbd55c384bd75

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 44s :heavy_check_mark: build-ansible-collection SUCCESS in 14m 22s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 52s :x: integration-amazon.aws-1 FAILURE in 6m 26s Skipped 43 jobs

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/d8708008f8bf4f168dbf458041c73686

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 08s :heavy_check_mark: build-ansible-collection SUCCESS in 16m 44s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 11s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 7m 51s Skipped 43 jobs

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/10d050db9404487596cd4696ef9f382e

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 50s :heavy_check_mark: build-ansible-collection SUCCESS in 15m 46s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 15s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 8m 38s Skipped 43 jobs

[abraverm]

Thank you @hakbailey, I have addressed your comments, could you give it another look?

[softwarefactory-project-zuul[bot]]

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/6d42b665a1cd484a9592c402fe86c811

:warning: ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection :x: build-ansible-collection RETRY_LIMIT in 6m 29s :x: ansible-test-splitter RETRY_LIMIT in 5m 44s :warning: integration-amazon.aws-1 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-2 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-3 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-4 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-5 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-6 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-7 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-8 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-9 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-10 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-11 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-12 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-13 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-14 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-15 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-16 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-17 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-18 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-19 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-20 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-21 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-amazon.aws-22 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-1 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-2 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-3 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-4 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-5 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-6 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-7 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-8 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-9 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-10 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-11 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-12 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-13 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-14 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-15 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-16 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-17 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-18 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-19 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-20 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-21 SKIPPED Skipped due to failed job build-ansible-collection :warning: integration-community.aws-22 SKIPPED Skipped due to failed job build-ansible-collection

[abraverm]

retry

[abraverm]

recheck

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/9e3fded273c148bca7e5cb5864a2295e

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 14s :heavy_check_mark: build-ansible-collection SUCCESS in 16m 42s :heavy_check_mark: ansible-test-splitter SUCCESS in 7m 27s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 8m 08s Skipped 43 jobs

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/547b1bef8c6e4006b7c4b9a2ff8914a9

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 37s :heavy_check_mark: build-ansible-collection SUCCESS in 13m 05s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 02s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 6m 44s Skipped 43 jobs

[softwarefactory-project-zuul[bot]]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. Warning: Error merging github.com/ansible-collections/amazon.aws for 2062,f57b8205dba1d4f91e7a9dcf261c9710e6ad2d0e

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/b406e0f3fa1b4715874d3a5abb360ba1

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 51s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 51s :heavy_check_mark: ansible-test-splitter SUCCESS in 4m 56s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 7m 15s Skipped 43 jobs

[softwarefactory-project-zuul[bot]]

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/3a5d41c3cec74eba8b7e864da44fe4f4

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 36s :heavy_check_mark: build-ansible-collection SUCCESS in 13m 16s :heavy_check_mark: ansible-test-splitter SUCCESS in 4m 55s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 5m 13s Skipped 43 jobs

[patchback[bot]]

Backport to stable-8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply c2e7aaf5cadbf7873698edd3dce59ec53583e893 on top of patchback/backports/stable-8/c2e7aaf5cadbf7873698edd3dce59ec53583e893/pr-2062

Backporting merged PR #2062 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
   

3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-8/c2e7aaf5cadbf7873698edd3dce59ec53583e893/pr-2062 upstream/stable-8
   

4. Now, cherry-pick PR #2062 contents into that branch:

   $ git cherry-pick -x c2e7aaf5cadbf7873698edd3dce59ec53583e893
   

   If it'll yell at you with something like fatal: Commit c2e7aaf5cadbf7873698edd3dce59ec53583e893 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x c2e7aaf5cadbf7873698edd3dce59ec53583e893
   

5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #2062 as close to the original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-8/c2e7aaf5cadbf7873698edd3dce59ec53583e893/pr-2062
   

7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

[abraverm]

Thank you very much for merging this PR, I was a bit busy and couldn't respond on time.