amazon.aws icon indicating copy to clipboard operation
amazon.aws copied to clipboard

s3_bucket transfer accleration

Open abraverm opened this issue 10 months ago • 13 comments

Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html

abraverm avatar Apr 09 '24 20:04 abraverm

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

github-actions[bot] avatar Apr 09 '24 20:04 github-actions[bot]

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/ab7140304faf441495fbf7b7dd4ffdc8

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 38s :heavy_check_mark: build-ansible-collection SUCCESS in 14m 13s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 25s :x: integration-amazon.aws-1 FAILURE in 7m 38s Skipped 43 jobs

Integation test failed on "AccessDenied", I have verified the integration test with my own AWS account with S3 admin user, so I have no idea what permissions are missing or how to change them for the CI to pass.

abraverm avatar Apr 09 '24 20:04 abraverm

ping

abraverm avatar Apr 23 '24 14:04 abraverm

@abraverm Thank you for taking time to work on this feature idea. Can you please open a pull request and add the missing permission PutBucketAccelerateConfiguration to this file https://github.com/mattclay/aws-terminator/blob/main/aws/policy/storage-services.yaml. Thank you.

alinabuzachis avatar Apr 23 '24 16:04 alinabuzachis

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/b2ae2c59bae74c6fa0a654b97d7a78f8

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 04s :heavy_check_mark: build-ansible-collection SUCCESS in 15m 46s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 40s :x: integration-amazon.aws-1 FAILURE in 6m 53s Skipped 43 jobs

I have updated the PR to match the recent changes but CI is still blocked by https://github.com/ansible/aws-ci-admin/pull/5

abraverm avatar Apr 26 '24 21:04 abraverm

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/90810f6758364fcaa3de95905aa4b004

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 39s :heavy_check_mark: build-ansible-collection SUCCESS in 15m 58s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 21s :x: integration-amazon.aws-1 FAILURE in 9m 09s Skipped 43 jobs

recheck

gravesm avatar May 08 '24 18:05 gravesm

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/1b5e85ba3e1647d1b4d9ede80f069b37

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 12s :heavy_check_mark: build-ansible-collection SUCCESS in 16m 45s :heavy_check_mark: ansible-test-splitter SUCCESS in 7m 45s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 10m 12s Skipped 43 jobs

@hakbailey thank you for the review, I have addressed your comments in my last commit

abraverm avatar May 15 '24 16:05 abraverm

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/d3db87fd2d8a401bb1da743bb1134220

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 13s :heavy_check_mark: build-ansible-collection SUCCESS in 15m 47s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 25s :x: integration-amazon.aws-1 RETRY_LIMIT in 7m 06s Skipped 43 jobs

I have no clue why the CI failed, the integration tests passed locally

abraverm avatar May 15 '24 17:05 abraverm

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/7a99e3c3826646d794d8f6fd64fbfff8

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 9m 02s :heavy_check_mark: build-ansible-collection SUCCESS in 24m 48s :x: ansible-test-splitter RETRY_LIMIT in 5m 26s :warning: integration-amazon.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

recheck

abraverm avatar Jun 06 '24 19:06 abraverm

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/7511cf92171e4bc9961458c3b27ccb44

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 46s :heavy_check_mark: build-ansible-collection SUCCESS in 16m 27s :x: ansible-test-splitter POST_FAILURE in 7m 39s :warning: integration-amazon.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-amazon.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter :warning: integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

recheck

abraverm avatar Jun 06 '24 20:06 abraverm

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/5ef36deb1322438eb3fa1d65298445cc

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 30s :heavy_check_mark: build-ansible-collection SUCCESS in 15m 19s :heavy_check_mark: ansible-test-splitter SUCCESS in 7m 09s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 8m 17s Skipped 43 jobs

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/d3e9be038fe14af6874192497901d0d6

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 34s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 19s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 57s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 6m 54s Skipped 43 jobs

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/5b1deee03e4f4e05926f1db8f8bf6024

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 18s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 45s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 04s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 6m 49s Skipped 43 jobs

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/29c4168d3b094ea08068d8721cb4ca0c

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 45s :heavy_check_mark: build-ansible-collection SUCCESS in 13m 07s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 10s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 6m 56s Skipped 43 jobs

Backport to stable-8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 3a6e448a93a24c474d281aa49492a3903b662ef7 on top of patchback/backports/stable-8/3a6e448a93a24c474d281aa49492a3903b662ef7/pr-2046

Backporting merged PR #2046 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
    
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-8/3a6e448a93a24c474d281aa49492a3903b662ef7/pr-2046 upstream/stable-8
    
  4. Now, cherry-pick PR #2046 contents into that branch:
    $ git cherry-pick -x 3a6e448a93a24c474d281aa49492a3903b662ef7
    
    If it'll yell at you with something like fatal: Commit 3a6e448a93a24c474d281aa49492a3903b662ef7 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 3a6e448a93a24c474d281aa49492a3903b662ef7
    
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #2046 as close to the original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-8/3a6e448a93a24c474d281aa49492a3903b662ef7/pr-2046
    
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Jun 28 '24 13:06 patchback[bot]

Thank you for merging the PR and I'm sorry for the delay on my part to respond.

abraverm avatar Jun 28 '24 17:06 abraverm