ansible-collections
Don't ignore IPv6 addresses when a single network interface is specified
SUMMARY
When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour.
ISSUE TYPE
- Bugfix Pull Request
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/f0f0938e2ed047be8345a6a48208e6c9
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 51s :heavy_check_mark: build-ansible-collection SUCCESS in 15m 15s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 40s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 22m 52s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 17m 07s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 13m 39s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 11m 13s :heavy_check_mark: integration-amazon.aws-5 SUCCESS in 8m 13s :heavy_check_mark: integration-amazon.aws-6 SUCCESS in 6m 02s :heavy_check_mark: integration-amazon.aws-7 SUCCESS in 7m 47s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 13m 18s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 11m 14s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 11m 43s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 7m 44s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 11m 37s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 12m 15s :heavy_check_mark: integration-amazon.aws-14 SUCCESS in 10m 59s :heavy_check_mark: integration-amazon.aws-15 SUCCESS in 7m 13s :heavy_check_mark: integration-amazon.aws-16 SUCCESS in 7m 57s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 6m 33s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 9m 24s :heavy_check_mark: integration-amazon.aws-19 SUCCESS in 8m 10s Skipped 25 jobs
![softwarefactory-project-zuul[bot] avatar](https://avatars.githubusercontent.com/in/6924?v=4 "Published by a pub.dev verified publisher"){kind=small}
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/24d75a89415246169022564c6b93dd48
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 59s :heavy_check_mark: build-ansible-collection SUCCESS in 14m 25s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 22s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 25m 44s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 11m 54s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 12m 40s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 12m 40s :heavy_check_mark: integration-amazon.aws-5 SUCCESS in 7m 21s :heavy_check_mark: integration-amazon.aws-6 SUCCESS in 7m 13s :heavy_check_mark: integration-amazon.aws-7 SUCCESS in 6m 43s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 13m 31s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 11m 19s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 8m 10s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 8m 45s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 12m 09s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 11m 02s :heavy_check_mark: integration-amazon.aws-14 SUCCESS in 9m 53s :heavy_check_mark: integration-amazon.aws-15 SUCCESS in 8m 48s :heavy_check_mark: integration-amazon.aws-16 SUCCESS in 9m 05s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 6m 51s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 8m 53s :heavy_check_mark: integration-amazon.aws-19 SUCCESS in 9m 14s Skipped 25 jobs
@maggu Thanks for taking the time to submit this PR. Can you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to? To help avoid regressions, please cover this change with integration tests.
@alinabuzachis Thanks for the reply and feedback. Regarding integration tests, there appear to currently be no tests at all for checking ec2_instance network settings.
What do you think would be the most appropriate approach for this? Adding it to ec2_instance_instance_*? Creating a new ec2_instance_network to test network settings? Something else, like ipv6_tests to test ivp6 settings across multiple modules?
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/be798846165641d6bf8894fc88059427
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 29s :heavy_check_mark: build-ansible-collection SUCCESS in 14m 26s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 42s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 25m 22s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 20m 52s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 13m 07s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 14m 25s :heavy_check_mark: integration-amazon.aws-5 SUCCESS in 9m 03s :heavy_check_mark: integration-amazon.aws-6 SUCCESS in 6m 28s :heavy_check_mark: integration-amazon.aws-7 SUCCESS in 12m 46s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 14m 05s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 8m 20s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 11m 43s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 12m 23s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 16m 52s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 12m 47s :heavy_check_mark: integration-amazon.aws-14 SUCCESS in 11m 44s :heavy_check_mark: integration-amazon.aws-15 SUCCESS in 8m 36s :heavy_check_mark: integration-amazon.aws-16 SUCCESS in 14m 17s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 12m 03s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 9m 16s :heavy_check_mark: integration-amazon.aws-19 SUCCESS in 12m 19s Skipped 25 jobs
@alinabuzachis Changelog fragment added, and rebased to current main.
I believe that integration tests might need a wider scope than this PR, considering that currently similar functionality isn't tested and there's no obvious place to add it. Such tests would obviously be beneficial though.
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/fccacaa5fdaf4440866b79267da6d42a
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 48s :heavy_check_mark: build-ansible-collection SUCCESS in 14m 46s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 17s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 28m 28s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 17m 13s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 14m 01s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 11m 30s :heavy_check_mark: integration-amazon.aws-5 SUCCESS in 12m 30s :heavy_check_mark: integration-amazon.aws-6 SUCCESS in 10m 15s :heavy_check_mark: integration-amazon.aws-7 SUCCESS in 13m 39s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 13m 53s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 16m 27s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 8m 40s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 12m 37s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 17m 14s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 15m 46s :heavy_check_mark: integration-amazon.aws-14 SUCCESS in 11m 59s :heavy_check_mark: integration-amazon.aws-15 SUCCESS in 11m 57s :heavy_check_mark: integration-amazon.aws-16 SUCCESS in 12m 41s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 8m 28s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 11m 42s :heavy_check_mark: integration-amazon.aws-19 SUCCESS in 14m 47s :heavy_check_mark: integration-community.aws-1 SUCCESS in 22m 57s :heavy_check_mark: integration-community.aws-2 SUCCESS in 10m 10s Skipped 23 jobs
Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing
https://ansible.softwarefactory-project.io/zuul/buildset/43b69c4e135e429c9f7a8cbd689dc787
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 00s :heavy_check_mark: build-ansible-collection SUCCESS in 19m 05s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 32s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 19m 07s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 13m 57s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 9m 00s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 8m 20s :heavy_check_mark: integration-amazon.aws-5 SUCCESS in 8m 20s :heavy_check_mark: integration-amazon.aws-6 SUCCESS in 7m 07s :x: integration-amazon.aws-7 FAILURE in 9m 43s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 9m 10s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 8m 05s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 12m 27s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 16m 54s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 17m 54s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 11m 39s :heavy_check_mark: integration-amazon.aws-14 SUCCESS in 12m 36s :heavy_check_mark: integration-amazon.aws-15 SUCCESS in 8m 49s :heavy_check_mark: integration-amazon.aws-16 SUCCESS in 10m 02s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 11m 42s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 7m 17s :heavy_check_mark: integration-amazon.aws-19 SUCCESS in 8m 28s :heavy_check_mark: integration-community.aws-1 SUCCESS in 46m 02s Skipped 24 jobs
Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/c09535cc6dd840e09f72c38c87693574
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 52s :heavy_check_mark: build-ansible-collection SUCCESS in 14m 53s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 46s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 29m 59s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 19m 39s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 13m 16s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 12m 02s :heavy_check_mark: integration-amazon.aws-5 SUCCESS in 11m 51s :heavy_check_mark: integration-amazon.aws-6 SUCCESS in 10m 19s :heavy_check_mark: integration-amazon.aws-7 SUCCESS in 10m 48s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 17m 45s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 15m 04s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 11m 20s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 7m 08s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 10m 55s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 10m 45s :heavy_check_mark: integration-amazon.aws-14 SUCCESS in 7m 24s :heavy_check_mark: integration-amazon.aws-15 SUCCESS in 7m 26s :heavy_check_mark: integration-amazon.aws-16 SUCCESS in 16m 24s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 8m 57s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 11m 25s :heavy_check_mark: integration-amazon.aws-19 SUCCESS in 8m 26s :heavy_check_mark: integration-community.aws-1 SUCCESS in 56m 53s Skipped 24 jobs
Backport to stable-7: 💚 backport PR created
✅ Backport PR branch: patchback/backports/stable-7/0d1a604b9aaa1c4e35274eaf3ebfe97fdd5fd00c/pr-1979
Backported as https://github.com/ansible-collections/amazon.aws/pull/2112
🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.
![patchback[bot] avatar](https://avatars.githubusercontent.com/in/21488?v=4 "Published by a pub.dev verified publisher"){kind=small}
Backport to stable-8: 💚 backport PR created
✅ Backport PR branch: patchback/backports/stable-8/0d1a604b9aaa1c4e35274eaf3ebfe97fdd5fd00c/pr-1979
Backported as https://github.com/ansible-collections/amazon.aws/pull/2113
🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.