amazon.aws
amazon.aws copied to clipboard
ansible-collections
Fix ec2_instance 'state' processing when exact_count is used
SUMMARY
Fixes (ie adds) 'state' processing for ec2_instance when 'exact_count' is used rather than 'instance_ids'
Note this only has effect when the exact_count is the same as the number of already existing, matching instances. In other words, it (still) has no effect when instances are either added or terminated as a result of exact_count. This is probably OK, as those other cases already have set target states (ie running or terminated respectively). But for the cases of managing the state of an existing group of instances, this adds that ability.
ISSUE TYPE
- Bugfix Pull Request
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
Currently, given an ec2_instance call where exact_count == existing instance count, any specification of 'state' has no effect.
Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/c7b5965b714f4c8a9f4e551845315d6a
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 21s :heavy_check_mark: build-ansible-collection SUCCESS in 13m 38s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 21s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 26m 16s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 17m 05s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 14m 16s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 11m 01s :heavy_check_mark: integration-amazon.aws-5 SUCCESS in 8m 54s :heavy_check_mark: integration-amazon.aws-6 SUCCESS in 11m 30s :heavy_check_mark: integration-amazon.aws-7 SUCCESS in 12m 27s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 7m 28s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 7m 24s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 13m 20s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 12m 08s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 10m 33s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 7m 30s :x: integration-amazon.aws-14 RETRY_LIMIT in 1m 36s :x: integration-amazon.aws-15 RETRY_LIMIT in 1m 33s :x: integration-amazon.aws-16 RETRY_LIMIT in 1m 34s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 8m 45s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 8m 09s Skipped 26 jobs
![softwarefactory-project-zuul[bot] avatar](https://avatars.githubusercontent.com/in/6924?v=4 "Published by a pub.dev verified publisher"){kind=small}
Components
plugins/modules/ec2_instance.py support: community maintainers: jillr ryansb s-hertel tremble
Metadata
waiting_on: maintainer changes_requested_by: null needs_info: False needs_revision: False needs_rebase: False merge_commits: [] too many files or commits: False mergeable_state: blocked shippable_status: None maintainer_shipits (module maintainers): 0 community_shipits (namespace maintainers): 0 ansible_shipits (core team members): 0 shipit_actors (maintainer or core team member): [] shipit_actors_other: [] automerge: automerge shipit test failed
@pluto00987 this PR contains the following merge commits:
- https://github.com/ansible-collections/amazon.aws/commit/9c307ce954aed605efe4eb4ddc451b31d192dd60
Please rebase your branch to remove these commits.
Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/81d8d819fcad4dabbd2dd1ca04695ffc
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 51s :heavy_check_mark: build-ansible-collection SUCCESS in 13m 16s :heavy_check_mark: ansible-test-splitter SUCCESS in 4m 51s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 25m 44s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 8m 07s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 15m 06s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 7m 49s :x: integration-amazon.aws-5 RETRY_LIMIT in 1m 32s :x: integration-amazon.aws-6 RETRY_LIMIT in 1m 32s :heavy_check_mark: integration-amazon.aws-7 SUCCESS in 12m 25s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 11m 04s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 9m 07s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 13m 02s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 6m 56s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 13m 11s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 8m 53s :heavy_check_mark: integration-amazon.aws-14 SUCCESS in 15m 41s :heavy_check_mark: integration-amazon.aws-15 SUCCESS in 9m 10s :heavy_check_mark: integration-amazon.aws-16 SUCCESS in 10m 12s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 8m 52s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 10m 40s Skipped 26 jobs
@pluto00987 thank for your contribution. Ideally there would be a new set of integration tests in https://github.com/ansible-collections/amazon.aws/blob/main/tests/integration/targets/ec2_instance_instance_multiple/tasks/main.yml to cover the scenario this is fixing. Unfortunately we are dealing with some CI issues right now and as you can see integration tests are not passing, but if you could add the test cases we'll be able to approve this more quickly once the CI issue are resolved. Please let me know if you have questions!
Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/880a0c9e6fbd44f4894c371d60c0253d
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 59s :heavy_check_mark: build-ansible-collection SUCCESS in 12m 52s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 06s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 26m 08s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 17m 19s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 13m 35s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 13m 22s :heavy_check_mark: integration-amazon.aws-5 SUCCESS in 8m 34s :heavy_check_mark: integration-amazon.aws-6 SUCCESS in 12m 28s :heavy_check_mark: integration-amazon.aws-7 SUCCESS in 12m 56s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 12m 35s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 8m 50s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 17m 27s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 13m 14s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 15m 31s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 12m 04s :heavy_check_mark: integration-amazon.aws-14 SUCCESS in 19m 20s :heavy_check_mark: integration-amazon.aws-15 SUCCESS in 10m 46s :heavy_check_mark: integration-amazon.aws-16 SUCCESS in 7m 42s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 7m 54s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 12m 33s :heavy_check_mark: integration-community.aws-1 SUCCESS in 25m 17s :heavy_check_mark: integration-community.aws-2 SUCCESS in 8m 30s :heavy_check_mark: integration-community.aws-3 SUCCESS in 47m 37s :heavy_check_mark: integration-community.aws-4 SUCCESS in 55m 53s :heavy_check_mark: integration-community.aws-5 SUCCESS in 8m 00s :heavy_check_mark: integration-community.aws-6 SUCCESS in 23m 44s :heavy_check_mark: integration-community.aws-7 SUCCESS in 34m 12s :heavy_check_mark: integration-community.aws-8 SUCCESS in 37m 09s :heavy_check_mark: integration-community.aws-9 SUCCESS in 24m 13s :heavy_check_mark: integration-community.aws-10 SUCCESS in 32m 23s :heavy_check_mark: integration-community.aws-11 SUCCESS in 32m 14s :x: integration-community.aws-12 TIMED_OUT in 1h 01m 09s :heavy_check_mark: integration-community.aws-13 SUCCESS in 20m 43s :heavy_check_mark: integration-community.aws-14 SUCCESS in 19m 08s :heavy_check_mark: integration-community.aws-15 SUCCESS in 25m 23s :heavy_check_mark: integration-community.aws-16 SUCCESS in 45m 17s :x: integration-community.aws-17 FAILURE in 59m 06s :heavy_check_mark: integration-community.aws-18 SUCCESS in 19m 50s :heavy_check_mark: integration-community.aws-19 SUCCESS in 20m 38s :heavy_check_mark: integration-community.aws-20 SUCCESS in 10m 37s Skipped 6 jobs
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/5858307b7f1444c7a2d802fd4ff8f317
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 40s :heavy_check_mark: build-ansible-collection SUCCESS in 14m 42s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 27s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 23m 02s :heavy_check_mark: integration-amazon.aws-2 SUCCESS in 13m 46s :heavy_check_mark: integration-amazon.aws-3 SUCCESS in 13m 38s :heavy_check_mark: integration-amazon.aws-4 SUCCESS in 11m 54s :heavy_check_mark: integration-amazon.aws-5 SUCCESS in 12m 46s :heavy_check_mark: integration-amazon.aws-6 SUCCESS in 7m 57s :heavy_check_mark: integration-amazon.aws-7 SUCCESS in 7m 52s :heavy_check_mark: integration-amazon.aws-8 SUCCESS in 12m 33s :heavy_check_mark: integration-amazon.aws-9 SUCCESS in 7m 24s :heavy_check_mark: integration-amazon.aws-10 SUCCESS in 8m 15s :heavy_check_mark: integration-amazon.aws-11 SUCCESS in 8m 44s :heavy_check_mark: integration-amazon.aws-12 SUCCESS in 13m 45s :heavy_check_mark: integration-amazon.aws-13 SUCCESS in 12m 08s :heavy_check_mark: integration-amazon.aws-14 SUCCESS in 12m 18s :heavy_check_mark: integration-amazon.aws-15 SUCCESS in 8m 00s :heavy_check_mark: integration-amazon.aws-16 SUCCESS in 12m 34s :heavy_check_mark: integration-amazon.aws-17 SUCCESS in 7m 55s :heavy_check_mark: integration-amazon.aws-18 SUCCESS in 7m 55s :heavy_check_mark: integration-amazon.aws-19 SUCCESS in 8m 19s Skipped 25 jobs