S3_bucket : Handle setting of permissions while acl is disabled

[GomathiselviS]

SUMMARY

As per boto3 aws documentation

When ObjectOwnership is BucketOwnerEnforced - Access control lists (ACLs) are disabled and no longer affect permissions.

Fixes #1137

ISSUE TYPE

• Bugfix Pull Request
• Docs Pull Request
• Feature Pull Request
• New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

[ansibullbot]

cc @alinabuzachis @jillr @lwade @s-hertel @tremble click here for bot help

[softwarefactory-project-zuul[bot]]

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 50s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 56s :heavy_check_mark: ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 53s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 03s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 40s :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 6m 25s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 6m 30s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 07s :heavy_check_mark: cloud-tox-py3 SUCCESS in 3m 06s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 59s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 13m 17s :warning: integration-amazon.aws-2 SKIPPED :warning: integration-amazon.aws-3 SKIPPED :warning: integration-amazon.aws-4 SKIPPED :warning: integration-amazon.aws-5 SKIPPED :warning: integration-amazon.aws-6 SKIPPED :warning: integration-amazon.aws-7 SKIPPED :warning: integration-amazon.aws-8 SKIPPED :warning: integration-amazon.aws-9 SKIPPED :warning: integration-amazon.aws-10 SKIPPED :warning: integration-amazon.aws-11 SKIPPED :warning: integration-amazon.aws-12 SKIPPED :warning: integration-amazon.aws-13 SKIPPED :warning: integration-amazon.aws-14 SKIPPED :warning: integration-amazon.aws-15 SKIPPED :warning: integration-amazon.aws-16 SKIPPED :warning: integration-amazon.aws-17 SKIPPED :warning: integration-amazon.aws-18 SKIPPED :warning: integration-community.aws-1 SKIPPED :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 15s

[tremble]

@GomathiselviS it would be good if you could add an integration test for this.

[softwarefactory-project-zuul[bot]]

Build failed.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 00s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 20s :x: ansible-test-sanity-aws-ansible-python38 FAILURE in 12m 40s :x: ansible-test-sanity-aws-ansible-2.12-python38 FAILURE in 9m 24s :x: ansible-test-sanity-aws-ansible-2.13-python38 FAILURE in 9m 35s :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 6m 31s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 5m 46s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 08s :heavy_check_mark: cloud-tox-py3 SUCCESS in 3m 37s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 37s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 9m 58s :warning: integration-amazon.aws-2 SKIPPED :warning: integration-amazon.aws-3 SKIPPED :warning: integration-amazon.aws-4 SKIPPED :warning: integration-amazon.aws-5 SKIPPED :warning: integration-amazon.aws-6 SKIPPED :warning: integration-amazon.aws-7 SKIPPED :warning: integration-amazon.aws-8 SKIPPED :warning: integration-amazon.aws-9 SKIPPED :warning: integration-amazon.aws-10 SKIPPED :warning: integration-amazon.aws-11 SKIPPED :warning: integration-amazon.aws-12 SKIPPED :warning: integration-amazon.aws-13 SKIPPED :warning: integration-amazon.aws-14 SKIPPED :warning: integration-amazon.aws-15 SKIPPED :warning: integration-amazon.aws-16 SKIPPED :warning: integration-amazon.aws-17 SKIPPED :warning: integration-amazon.aws-18 SKIPPED :warning: integration-community.aws-1 SKIPPED :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 34s

[github-actions[bot]]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

[softwarefactory-project-zuul[bot]]

Build succeeded.

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 51s :heavy_check_mark: build-ansible-collection SUCCESS in 6m 04s :heavy_check_mark: ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 57s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 42s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 07s :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 6m 24s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 6m 19s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 13s :heavy_check_mark: cloud-tox-py3 SUCCESS in 3m 35s :heavy_check_mark: ansible-test-splitter SUCCESS in 3m 08s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 10m 01s :warning: integration-amazon.aws-2 SKIPPED :warning: integration-amazon.aws-3 SKIPPED :warning: integration-amazon.aws-4 SKIPPED :warning: integration-amazon.aws-5 SKIPPED :warning: integration-amazon.aws-6 SKIPPED :warning: integration-amazon.aws-7 SKIPPED :warning: integration-amazon.aws-8 SKIPPED :warning: integration-amazon.aws-9 SKIPPED :warning: integration-amazon.aws-10 SKIPPED :warning: integration-amazon.aws-11 SKIPPED :warning: integration-amazon.aws-12 SKIPPED :warning: integration-amazon.aws-13 SKIPPED :warning: integration-amazon.aws-14 SKIPPED :warning: integration-amazon.aws-15 SKIPPED :warning: integration-amazon.aws-16 SKIPPED :warning: integration-amazon.aws-17 SKIPPED :warning: integration-amazon.aws-18 SKIPPED :warning: integration-community.aws-1 SKIPPED :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 18s

[GomathiselviS]

For the sake of getting this bug fixed, +1

I agree with @goneri about the danger of manipulating module.params, @GomathiselviS would you be able to clean that up separately?

@tremble @GomathiselviS I will open a separate PR to do the same.

[softwarefactory-project-zuul[bot]]

Build succeeded (gate pipeline).

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 14s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 51s :heavy_check_mark: ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 26s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 34s :heavy_check_mark: ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 33s :heavy_check_mark: ansible-test-units-amazon-aws-python36 SUCCESS in 6m 04s :heavy_check_mark: ansible-test-units-amazon-aws-python38 SUCCESS in 5m 56s :heavy_check_mark: ansible-test-units-amazon-aws-python39 SUCCESS in 6m 38s :heavy_check_mark: cloud-tox-py3 SUCCESS in 3m 04s :heavy_check_mark: ansible-test-splitter SUCCESS in 2m 51s :heavy_check_mark: integration-amazon.aws-1 SUCCESS in 9m 36s :warning: integration-amazon.aws-2 SKIPPED :warning: integration-amazon.aws-3 SKIPPED :warning: integration-amazon.aws-4 SKIPPED :warning: integration-amazon.aws-5 SKIPPED :warning: integration-amazon.aws-6 SKIPPED :warning: integration-amazon.aws-7 SKIPPED :warning: integration-amazon.aws-8 SKIPPED :warning: integration-amazon.aws-9 SKIPPED :warning: integration-amazon.aws-10 SKIPPED :warning: integration-amazon.aws-11 SKIPPED :warning: integration-amazon.aws-12 SKIPPED :warning: integration-amazon.aws-13 SKIPPED :warning: integration-amazon.aws-14 SKIPPED :warning: integration-amazon.aws-15 SKIPPED :warning: integration-amazon.aws-16 SKIPPED :warning: integration-amazon.aws-17 SKIPPED :warning: integration-amazon.aws-18 SKIPPED :warning: integration-community.aws-1 SKIPPED :warning: integration-community.aws-2 SKIPPED :warning: integration-community.aws-3 SKIPPED :warning: integration-community.aws-4 SKIPPED :warning: integration-community.aws-5 SKIPPED :warning: integration-community.aws-6 SKIPPED :warning: integration-community.aws-7 SKIPPED :warning: integration-community.aws-8 SKIPPED :warning: integration-community.aws-9 SKIPPED :warning: integration-community.aws-10 SKIPPED :warning: integration-community.aws-11 SKIPPED :warning: integration-community.aws-12 SKIPPED :warning: integration-community.aws-13 SKIPPED :warning: integration-community.aws-14 SKIPPED :warning: integration-community.aws-15 SKIPPED :warning: integration-community.aws-16 SKIPPED :warning: integration-community.aws-17 SKIPPED :warning: integration-community.aws-18 SKIPPED :heavy_check_mark: ansible-test-changelog SUCCESS in 2m 20s