react-poke-sprites icon indicating copy to clipboard operation
react-poke-sprites copied to clipboard

Published 20 hours ago • verified publisher icon anshumanv

Nidoran male and female

Open Lisser opened this issue 7 years ago • 2 comments

Great component, thanks! Just checked gen 1, but Nidoran male and female don't work.

Id 29 and 32

Lisser avatar Jan 19 '18 20:01 Lisser

Thanks for bringing this to light, I investigated the issue and it seems that one of the submodule which fetches gif links has a flawed name return - https://github.com/jackrzhang/pokemon-gif/blob/9a3d08786da13739c988d34144da58254d213720/lib/pokedex-number-to-name.js#L213

No gif returned for http://www.pokestadium.com/sprites/xy/nidoran.gif but returned for http://www.pokestadium.com/sprites/xy/nidoranf.gif http://www.pokestadium.com/sprites/xy/nidoranm.gif

anshumanv avatar Jan 19 '18 20:01 anshumanv

29,32 after converting number to name is converted to nidoran which doesn't exist. It should be either nidoranm or nidoranf

anshumanv avatar Jan 19 '18 20:01 anshumanv