ongaku icon indicating copy to clipboard operation
ongaku copied to clipboard

Merge the preferences button (Improve UI as well) and info button

Open anshumanv opened this issue 6 years ago • 11 comments

Currently, we have preferences and info button aligned side by side. Let's merge them into a single button called settings, and by clicking the button we have foldable sections to preferences and keycodes each, a good example is in http://openings.moe (Menu button) we need something along those lines.

  • [x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • [x] This issue is for enhancement/bug fixing.
  • [ ] This issue is an addition to JSON database.
  • [x] I have gone through Contribution Guidelines.
  • [ ] Assign this issue to me.

anshumanv avatar Oct 24 '17 13:10 anshumanv

Are you sure?

In my opinion the way you have the buttons set looks good and is a quick access which is better.

SoldierCorp avatar Oct 24 '17 21:10 SoldierCorp

In that case, let's improve the keycode info button, I don't like the current button, it's buggy and not well modeled.

anshumanv avatar Oct 26 '17 15:10 anshumanv

Agree

SoldierCorp avatar Oct 26 '17 15:10 SoldierCorp

In that case, please improve the info button UI and send a PR. 😄

anshumanv avatar Oct 26 '17 15:10 anshumanv

What about making it behave similar to the preference button? or do you have something else in mind?

OuKevin avatar Nov 08 '17 00:11 OuKevin

@OuKevin let's make it similar to the preferences button (with improved UI), please send a PR.

anshumanv avatar Nov 08 '17 03:11 anshumanv

Remove Hacktoberfest label

starkblaze01 avatar Dec 15 '17 05:12 starkblaze01

Help still needed?

Shiroraven avatar Jan 21 '19 16:01 Shiroraven

Sure, please feel free to send a PR @Shiroraven 😄

anshumanv avatar Jan 21 '19 16:01 anshumanv

@anshumanv is there any way to contact you to discuss what changes need to be made to the UI, because from reading the issue alone i don't quite understand.

Shiroraven avatar Jan 26 '19 21:01 Shiroraven

Sure @Shiroraven you can contact me on telegram, my handle - @anshumanv

anshumanv avatar Jan 27 '19 04:01 anshumanv