Andy

Results 37 comments of Andy

Whats your opinion on this? If you have the same opinion like me so I would provide a PR.

Could you give me permissions to push my branch and raise a PR? I finished and fix the bug.

PR s now available: https://github.com/cloudnc/ngx-sub-form/pull/263

I changed the emitValue property to true if the form is disabled or enabled, because the validation of sub forms is not processed if the form is enabled or disabled....

yes we should cover this with a e2e test. I do that at the weekend or monday.

I think we have another issue with enable/disable. It emits the form value as often we have sub forms. So we should emit a value only its changed. Maybe a...

I created an e2e test to validate the form errors after enable and disable the form. I also fixed the issue within the old implementation.

We should bring this into version 6.x.x. and 5.3.x.

@maxime1992 could you please take a look on that?