monument icon indicating copy to clipboard operation
monument copied to clipboard

Expand test coverage for utils/parser.js

Open designfrontier opened this issue 9 years ago • 6 comments

https://coveralls.io/builds/4658528 Looks like it is covered about 90%...

Locally you can get this number by running npm test. That creates an output to console and the more useful coverage directory. In the coverage directory (run it with a static server like http-server) you can drill into the coverage in the browser and see exactly what lines are not tested currently.

designfrontier avatar Jan 15 '16 22:01 designfrontier

Hello, I would like to give this a shot.

barrotsteindev avatar Dec 16 '16 10:12 barrotsteindev

@barrotsteindev awesome! Let me know if you have questions or need a hand with anything

designfrontier avatar Dec 16 '16 22:12 designfrontier

Well I have looked into it and it seems like this issue is no longer relevant. Could you please just make sure I'm not missing anything? Thanks in advance.

barrotsteindev avatar Dec 20 '16 20:12 barrotsteindev

@barrotsteindev It looks like the coverage is still about 93% with a couple of error states that are untested. Specifically lines 60 and 84 are not executed in the test suite. If you wanted to write some tests to get them under coverage that would be great.

There might need to be some refactoring to make that a little easier to do... but I think it is possible as is with some correct setup of the params passed into the function

designfrontier avatar Jan 26 '17 17:01 designfrontier

@designfrontier I have started to work on this in a forked repo: https://github.com/barrotsteindev/monument/blob/utils_parser_tests I haven't been able to test line 87 in the parser.js, and seem kind of stuck. Would you have a tip or an idea how to get this line to be executed? Thanks in advance.

barrotsteindev avatar Feb 01 '17 18:02 barrotsteindev

Hi @designfrontier Myself Satabrata Paul. a passionate backend and cloud developer from India I would like to get started in contributing to this project , for Hacktoberfest this year . i.e. 2022 I have previously contributed to major open source projects (presently working with The Linux Foundation - LFX Mentorship) Can we schedule a 1:1 call over gmeet ? I just wanted to understand the code and the repository a bit better which would in turn help me pickup the issues

I am located in India (IST) Here is my email id for reference : [email protected]

Hoping for a response soon !!!

SatabrataPaul-GitAc avatar Sep 25 '22 19:09 SatabrataPaul-GitAc