laravel-health-check icon indicating copy to clipboard operation
laravel-health-check copied to clipboard

Add health-check:health command

Open idsulik opened this issue 4 years ago • 8 comments

Add command to check helath in console mode - health-check:health. Made some refactoring

idsulik avatar Nov 10 '20 10:11 idsulik

Hi @idsulik,

I can see this is still WIP.

Can I refer you to the linked issue, so you've got a better idea of what we'd like this command to do? https://github.com/ukfast/laravel-health-check/issues/22

Feel free to tag me if you have any questions! 😄

tylerwoonton avatar Nov 10 '20 19:11 tylerwoonton

Hi @tylerwoonton , I thought it's ready, but tests fails and I don't understand why it fails only on PHP 7.1 PendingCommand does contains expectsTable method, but fails say it's not... image

idsulik avatar Nov 11 '20 07:11 idsulik

@tylerwoonton , PR is ready) tests code a little messy because of php5 && laravel 5 supports.

idsulik avatar Nov 11 '20 08:11 idsulik

@tylerwoonton , PR is ready) tests code a little messy because of php5 && laravel 5 supports.

@idsulik Excellent. I'll take a look. Thanks!

tylerwoonton avatar Nov 11 '20 08:11 tylerwoonton

I think it'll better to add ability to include or exclude specific checks, so I add --only and --except options to status command. Whay do you think, @tylerwoonton , @Gman98ish ?

idsulik avatar Nov 11 '20 11:11 idsulik

I think it'll better to add ability to include or exclude specific checks, so I add --only and --except options to status command. Whay do you think, @tylerwoonton , @Gman98ish ?

@idsulik I like that idea! I think by default it should run all the checks and add --only and --except for those use-cases.

tylerwoonton avatar Nov 11 '20 11:11 tylerwoonton

I think it'll better to add ability to include or exclude specific checks, so I add --only and --except options to status command. Whay do you think, @tylerwoonton , @Gman98ish ?

@idsulik I like that idea! I think by default it should run all the checks and add --only and --except for those use-cases.

Yeah, by default it checks all the checks, but you can pass --only OR --except to run/exclude specific checks.

idsulik avatar Nov 11 '20 11:11 idsulik

I think it'll better to add ability to include or exclude specific checks, so I add --only and --except options to status command. Whay do you think, @tylerwoonton , @Gman98ish ?

@idsulik I like that idea! I think by default it should run all the checks and add --only and --except for those use-cases.

Yeah, by default it checks all the checks, but you can pass --only OR --except to run/exclude specific checks.

That sounds good to me!

tylerwoonton avatar Nov 11 '20 11:11 tylerwoonton