advanced-logistics-system icon indicating copy to clipboard operation
advanced-logistics-system copied to clipboard

Update to .16?

Open CoreyJ87 opened this issue 7 years ago • 13 comments

Is this mod still maintained? Is it possible it will be updated to .16. This mod should be part of the game. Its soooo nice. Hope to see it update. Thanks

CoreyJ87 avatar Dec 18 '17 18:12 CoreyJ87

Hello there,

I would have asked the same thing but don't know if the dev is still around. If I get the time and am knowledgable enough, I'll look into it.

Anyway, I'm with @CoreyJ87 on this one.

@anoutsider Are you still playing factorio?

FHoulbreque avatar Dec 20 '17 16:12 FHoulbreque

Not playing as much anymore.. last playthrough was almost a year ago, will look into updating it this weekend :)

anoutsider avatar Dec 20 '17 16:12 anoutsider

@anoutsider Thank you very much, I'll have to learn a bit more about LUA and Factorio API if I want to be of help in the future ;) More a PHP, JS and Java guy myself, or even C#, but LUA / Python isn't something I tried too much, must dive into it ;).

FHoulbreque avatar Dec 20 '17 19:12 FHoulbreque

Awesome. I tried. Im more of a node guy and there is alot about the game/api that I dont understand yet. So I was having trouble. I updated the info.json and added the icon_size to the prototypes. There was another error after I did those. And that was this 1.832 Error ModManager.cpp:883: Failed to load core data gui-style: Value must be a dictionary in property tree at ROOT 1.866 Error Util.cpp:49: Error while loading gui-style prototype "default" (gui-style): Parent style not found: als_button

CoreyJ87 avatar Dec 20 '17 20:12 CoreyJ87

@CoreyJ87 Style must have a parent property, as mentionned here : https://goo.gl/7f1e9N

You must check in the main.lua file that there's a parent for each style defined here.

Issue seems to be on line 524. Don't know what should be the correct parent value as there's one which is defined before.

FHoulbreque avatar Dec 20 '17 22:12 FHoulbreque

@CoreyJ87 I think I found what's maybe is the issue tere.

Here the modding update log: https://goo.gl/j5Vz4E

And look at what I found there:

  • Moved Mod-gui button flow to gui.top

FHoulbreque avatar Dec 21 '17 02:12 FHoulbreque

Awesome @FrancoisH nice finds. I'm still new to factorio and brand new to looking at the mods lua. Their changelog is so big too lol. But anyways. I'll see if I can figure out how to fix it. Otherwise I imagine this should shorten the time it would take @anoutsider to fix it.

CoreyJ87 avatar Dec 23 '17 01:12 CoreyJ87

@CoreyJ87 You should check the pull request and look at my fork. Maybe even try it... I think it's fixed... or at least it seems to be as far as I was able to test it.

This fork should save time for @anoutsider, I'm pretty sure ;)

Here's my fork: https://github.com/FrancoisH/advanced-logistics-system

FHoulbreque avatar Dec 23 '17 02:12 FHoulbreque

damn man that was a whole lot more than I expected. Nice job. I'll test it tonight.

CoreyJ87 avatar Dec 23 '17 02:12 CoreyJ87

@FrancoisH still broken. It loads but upon trying to join the server I get this 7.937 Error ServerMultiplayerManager.cpp:95: MultiplayerManager failed: "Error while running on_init: LuaLogisticNetwork doesn't contain key full_or_satisfied_requesters. stack traceback: __advanced-logistics-system__/control.lua:764: in function 'getLogisticNetworks' __advanced-logistics-system__/control.lua:362: in function 'initForce' __advanced-logistics-system__/control.lua:348: in function 'initForces' __advanced-logistics-system__/control.lua:151: in function 'initAll' __advanced-logistics-system__/control.lua:14: in function <__advanced-logistics-system__/control.lua:13>" 7.937 Info ServerMultiplayerManager.cpp:696: mapTick(4294967295) changing state from(CreatingGame) to(InitializationFailed)

CoreyJ87 avatar Jan 22 '18 17:01 CoreyJ87

Hmmm, looked at the fork but no release yet for it so why forking when not deploying any release file? SHould we do a self pack? No, definitly no!

chaos234 avatar Feb 11 '18 09:02 chaos234

@chaos234 doing a self pack is the norm when making changes to a mod before release. Its not that hard to click "download" and rename the zip folder.

Danielv123 avatar Feb 11 '18 13:02 Danielv123

This fork seems to be working https://github.com/lingo/advanced-logistics-system

maxosprojects avatar Apr 13 '18 08:04 maxosprojects