Alex North

Results 126 comments of Alex North

Sounds like we need a reproducible build first, then. #171

> Another idea ... is to execute the bundle size update in a `merge_group`. We do in fact already use merge queues, though I am also about to suggest we...

> > However, calculating bundle size there wouldn't give anyone an opportunity to notice changes before committing them. We could bisect later to find big changes though. > > We...

Let's start with (1). I reckon compare with the current value in file, and allow some small delta to be present without making any PR noise. - If the author...

Hold on, can we discuss this? I've had a brief look at those docs. They look like they could be mostly generated from the code by some automation? Were they?...

> is this still needded? If they're not done yet, yes.

I think there's reasonable justification for doing the breaking approach, if we can do it soon. Receiving funds unexpectedly would very likely lead to their loss. I would say that...

Just to confirm, @Stebalien, given the location of this issue, you're proposing this as a safety feature for the built-in actors runtime (which is essentially just a support library). It's...

Related discussion about being able to refuse bare sends of value (which would require VM support): https://github.com/filecoin-project/ref-fvm/issues/835

I've renamed this "Reject unexpected transfers of value" to reflect the behavioural change. I concur that support in the Runtime would be a good way to get it. This will...