Storz icon indicating copy to clipboard operation
Storz copied to clipboard

Aniket/logout modal

Open Aniket1026 opened this issue 2 years ago • 7 comments

Description

Successfully added the logout Modal which popups when Logout button is clicked asking the user if he wants to logout or not ?

Fixes # (issue)

Type of change

  • [x] New feature (non-breaking change which adds functionality)
    • The Popup Modal is an additional functionality .
    • The conflicts arrived during has been resolved and they doesn't break the code.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Aniket1026 avatar Oct 03 '22 11:10 Aniket1026

Hey, the color of the button text and the font style is not according to the UI. Please fix those.

Current: image

Required: image

anomic30 avatar Oct 03 '22 12:10 anomic30

Why did you expose the API keys? It should be kept empty. Kindly go through our main branch to check the content of the .env.example

Yeahh I did it by mistake . I'll remove them

Aniket1026 avatar Oct 03 '22 12:10 Aniket1026

Hey, you forgot to remove the API keys from the server/.env.example also. Also, try to follow the style guidelines.

anomic30 avatar Oct 03 '22 13:10 anomic30

I'm just First timer in hacktoberfest. Sorry for the inconvenience . I've removed the keys from both the files . Also When the popup Appears. I'm not able to make the background a bit transparent . Do tell if i've to make anymore improvements in my PR.

Aniket1026 avatar Oct 03 '22 13:10 Aniket1026

I've changed the background also for when the popup appears . You can check it for potential mistakes 😅

Aniket1026 avatar Oct 03 '22 17:10 Aniket1026

@Sneakad Done . Does it looks fine now ?

Aniket1026 avatar Oct 05 '22 07:10 Aniket1026

@anomic30 @Sneakad any further updates for me?

Aniket1026 avatar Oct 11 '22 16:10 Aniket1026