namada icon indicating copy to clipboard operation
namada copied to clipboard

Increase code coverage for shell/finalize_block.rs

Open batconjurer opened this issue 3 years ago • 1 comments

Based on a partial code coverage report for tarpaulin, we should increase the code coverage of apps/src/lib/node/ledger/shell/finalize_block.rs. This following code paths should be covered

  • [ ] The update_state function (this covered in PR anoma/anoma#377 )
  • [ ] Test finalize block on a tx with an invalid signature.
  • [ ] Test update_epoch
  • [ ] test a gas overflow

batconjurer avatar Feb 14 '22 12:02 batconjurer

@batconjurer is this still accurate?

cwgoes avatar Jan 12 '23 16:01 cwgoes

@batconjurer @grarco @Fraccaman how relevant is this issue still?

brentstone avatar Apr 10 '24 00:04 brentstone

@batconjurer @grarco @Fraccaman how relevant is this issue still?

No. It's way too out of date.

batconjurer avatar Apr 10 '24 08:04 batconjurer

No. It's way too out of date.

batconjurer avatar Apr 10 '24 08:04 batconjurer