namada icon indicating copy to clipboard operation
namada copied to clipboard

Fix compiling with `abcipp` and set up CI to check it

Open james-chf opened this issue 2 years ago • 1 comments

ABCI 0.19 (formerly known as ABCI++) is coming in Tendermint v0.38 and will provide us with vote extensions, which was used by the original design of the Ethereum bridge. Code to do with it is guarded behind the abcipp flag, and --no-default-features should be used also. We should run CI to make sure that our ABCI 0.19 code continues to compile/pass tests.

Compiling with abcipp currently doesn't work on main or eth-bridge-integration branches (as of 2022-11-04). We should fix up in main first and have a CI job to at least cargo check it, then do the same for eth-bridge-integration.

  • [ ] fix in main https://github.com/anoma/namada/pull/754
  • [ ] fix in eth-bridge-integration
  • [ ] CI in main https://github.com/anoma/namada/pull/824
  • [ ] CI in eth-bridge-integration

james-chf avatar Sep 21 '22 17:09 james-chf

This has broken a couple of times

james-chf avatar Oct 28 '22 13:10 james-chf

@james-chf is this relevant any more?

cwgoes avatar Jan 13 '23 19:01 cwgoes

This is done

james-chf avatar Jan 16 '23 10:01 james-chf